devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Kumar Gala <galak@codeaurora.org>, Suman Anna <s-anna@ti.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Andy Gross <agross@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex
Date: Thu, 12 Mar 2015 04:14:31 -0700	[thread overview]
Message-ID: <20150312111430.GU26334@sonymobile.com> (raw)
In-Reply-To: <20150312095136.GA30145@leverpostej>

On Thu 12 Mar 02:51 PDT 2015, Mark Rutland wrote:

> On Fri, Feb 27, 2015 at 10:30:16PM +0000, Bjorn Andersson wrote:
> > Add binding documentation for the Qualcomm Hardware Mutex.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> > ---
> > 
> > I think the conclusion on the dt binding discussion for hwspinlocks was that
> > we're down to having the #hwlock-cells intact. So this version includes that,
> > but non of the other previously discussed properties.
> > 
> > Changes since v5:
> > - Extracted the dt binding documentation into a separate patch
> > - Moved the driver to consume a syscon
> 
> I'm a little confused here. Why are we now using a syscon? I thought the
> set of registers for the block was well-defined.
> 

The sfpb-mutex registers make up a block (according to my
documentation), but after discussing tcsr with Andy Gross we concluded
that although the tcsr-mutex registers are layed out consecutively in
the tcsr, they are not alone in the block.

Further more Andy introduced the tcsr-syscon binding in his work to
support DMA on GSBI (uart/i2c/spi), so that's why I had to make this
change.

Preferrably this would have showed up before v6...

> If there's a link to some previous discussion on that point, it would be
> helpful.
> 

Unfortunately there isn't, as we discussed this mainly face to face a
few weeks back.

Regards,
Bjorn

  reply	other threads:[~2015-03-12 11:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 22:30 [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex Bjorn Andersson
2015-03-12  9:29 ` Ohad Ben-Cohen
2015-04-01 21:32   ` Tim Bird
2015-04-02  4:40     ` Ohad Ben-Cohen
2015-04-02 18:11       ` Tim Bird
     [not found]         ` <CA+bK7J6rXtF54Tp1+mkDbv8Hok88MVZeC+mLvjjGjzZ4KtTHEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-03 13:55           ` Ohad Ben-Cohen
2015-04-06 16:22             ` Tim Bird
     [not found]               ` <CA+bK7J7OB2bbGna7y-O4egF-rhig-bdf1W5Uw+GG7F0VjDepUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-06 16:31                 ` Ohad Ben-Cohen
2015-04-06 16:48                   ` Bjorn Andersson
2015-04-06 19:04                     ` Ohad Ben-Cohen
2015-04-13 10:23                       ` Ohad Ben-Cohen
2015-04-15 19:40                         ` Rob Herring
     [not found]                           ` <CAL_Jsq+GhhhoHgRDOkK4=oWtSVmvw=UpLoU-Ey5M7tdNi5OZ2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-16 12:01                             ` Mark Rutland
2015-03-12  9:51 ` Mark Rutland
2015-03-12 11:14   ` Bjorn Andersson [this message]
2015-03-16 22:35 ` Jeffrey Hugo
     [not found] ` <1425076217-10415-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2015-03-02  5:05   ` Andy Gross
2015-04-14 19:18   ` Kumar Gala
2015-04-15 18:20     ` Ohad Ben-Cohen
2015-04-16 11:52 ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312111430.GU26334@sonymobile.com \
    --to=bjorn.andersson@sonymobile.com \
    --cc=Pawel.Moll@arm.com \
    --cc=agross@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).