Re: [PATCH] libfdt: Add fdt_path_offset_namelen()

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

On Tue, Mar 10, 2015 at 09:47:44AM -0400, Peter Hurley wrote:
> Hi David,
> 
> On 03/09/2015 08:17 PM, David Gibson wrote:
> > On Fri, Mar 06, 2015 at 10:12:38AM -0500, Peter Hurley wrote:
> >> Properties may contain path names which are not NUL-terminated.
> >> For example, the 'stdout-path' property allows the form 'path:options',
> >> where the ':' character terminates the path specifier.
> >>
> >> Allow these path names to be used in-place for path descending;
> >> add fdt_path_offset_namelen(), which limits the path name to 'namelen'
> >> characters.
> >>
> >> Reimplement fdt_path_offset() as a trivial wrapper.
> >>
> >> Signed-off-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
> > 
> > I think this function is a good idea, however I would like to see a
> > testcase for it.
> 
> Sure, I can do that.
> 
> I assume you mean a path name with non-NUL termination because
> the fdt_path_offset() tests are already exercising the
> fdt_path_offset_name() implementation.

Yes, I mean the non-\0-terminated case.  Or more specifically still,
making sure that if you call fdt_path_offset_namelen() on a portion of
a longer path, it correctly gives you the offset for only the partial
path.

That said, there may be some other edge cases that could do with
testing too, if you have time.  In particular I'm thinking of paths
where there are repeated '/' character, and paths ending with one or
more '/' characters.

> Is there a readme somewhere regarding the test matrix (ie.,
> which dts files go with which tests)?

I'm afraid not, apart from the test runner script itself.  I'm not
sure quite what information you're after here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]