devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral
@ 2015-03-17  9:43 Roger Quadros
  2015-03-17 14:54 ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Roger Quadros @ 2015-03-17  9:43 UTC (permalink / raw)
  To: tony; +Cc: balbi, nm, linux-omap, devicetree, Roger Quadros

Now that we have EXTCON_USB_GPIO queued for v4.1, revert
commit addfcde7c485 ("ARM: dts: dra7x-evm: beagle-x15: Fix USB Host")

On these EVMs, the USB cable state has to be determined via the
ID pin tied to a GPIO line. We use the gpio-usb-extcon driver
to read the ID pin and the extcon framework to forward
the USB cable state information to the USB driver so the
controller can be configured in the right mode (host/peripheral).

Gets USB peripheral mode to work on this EVM.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 8 ++++++++
 arch/arm/boot/dts/dra7-evm.dts          | 8 ++++++++
 arch/arm/boot/dts/dra72-evm.dts         | 8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index bd48dba..170fbf9 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -548,6 +548,14 @@
 	pinctrl-0 = <&usb1_pins>;
 };
 
+&omap_dwc3_1 {
+	extcon = <&extcon_usb1>;
+};
+
+&omap_dwc3_2 {
+	extcon = <&extcon_usb2>;
+};
+
 &usb2 {
 	dr_mode = "peripheral";
 };
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b1bd06c..aa46590 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -541,6 +541,14 @@
 	};
 };
 
+&omap_dwc3_1 {
+	extcon = <&extcon_usb1>;
+};
+
+&omap_dwc3_2 {
+	extcon = <&extcon_usb2>;
+};
+
 &usb1 {
 	dr_mode = "peripheral";
 	pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
index daf2811..ce0390f 100644
--- a/arch/arm/boot/dts/dra72-evm.dts
+++ b/arch/arm/boot/dts/dra72-evm.dts
@@ -377,6 +377,14 @@
 	phy-supply = <&ldo4_reg>;
 };
 
+&omap_dwc3_1 {
+	extcon = <&extcon_usb1>;
+};
+
+&omap_dwc3_2 {
+	extcon = <&extcon_usb2>;
+};
+
 &usb1 {
 	dr_mode = "peripheral";
 	pinctrl-names = "default";
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral
  2015-03-17  9:43 [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral Roger Quadros
@ 2015-03-17 14:54 ` Felipe Balbi
  2015-03-17 18:02   ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2015-03-17 14:54 UTC (permalink / raw)
  To: Roger Quadros; +Cc: tony, balbi, nm, linux-omap, devicetree

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Hi,

On Tue, Mar 17, 2015 at 11:43:51AM +0200, Roger Quadros wrote:
> Now that we have EXTCON_USB_GPIO queued for v4.1, revert
> commit addfcde7c485 ("ARM: dts: dra7x-evm: beagle-x15: Fix USB Host")
> 
> On these EVMs, the USB cable state has to be determined via the
> ID pin tied to a GPIO line. We use the gpio-usb-extcon driver
> to read the ID pin and the extcon framework to forward
> the USB cable state information to the USB driver so the
> controller can be configured in the right mode (host/peripheral).
> 
> Gets USB peripheral mode to work on this EVM.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

on subject: x14 ? other than that

Reviewed-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral
  2015-03-17 14:54 ` Felipe Balbi
@ 2015-03-17 18:02   ` Tony Lindgren
  2015-03-18  9:38     ` Roger Quadros
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2015-03-17 18:02 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: Roger Quadros, nm, linux-omap, devicetree

* Felipe Balbi <balbi@ti.com> [150317 07:55]:
> Hi,
> 
> On Tue, Mar 17, 2015 at 11:43:51AM +0200, Roger Quadros wrote:
> > Now that we have EXTCON_USB_GPIO queued for v4.1, revert
> > commit addfcde7c485 ("ARM: dts: dra7x-evm: beagle-x15: Fix USB Host")
> > 
> > On these EVMs, the USB cable state has to be determined via the
> > ID pin tied to a GPIO line. We use the gpio-usb-extcon driver
> > to read the ID pin and the extcon framework to forward
> > the USB cable state information to the USB driver so the
> > controller can be configured in the right mode (host/peripheral).
> > 
> > Gets USB peripheral mode to work on this EVM.
> > 
> > Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> on subject: x14 ? other than that
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Applying into omap-for-v4.1/dt-v2 with the subject line fixed.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral
  2015-03-17 18:02   ` Tony Lindgren
@ 2015-03-18  9:38     ` Roger Quadros
  0 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2015-03-18  9:38 UTC (permalink / raw)
  To: Tony Lindgren, Felipe Balbi; +Cc: nm, linux-omap, devicetree

On 17/03/15 20:02, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [150317 07:55]:
>> Hi,
>>
>> On Tue, Mar 17, 2015 at 11:43:51AM +0200, Roger Quadros wrote:
>>> Now that we have EXTCON_USB_GPIO queued for v4.1, revert
>>> commit addfcde7c485 ("ARM: dts: dra7x-evm: beagle-x15: Fix USB Host")
>>>
>>> On these EVMs, the USB cable state has to be determined via the
>>> ID pin tied to a GPIO line. We use the gpio-usb-extcon driver
>>> to read the ID pin and the extcon framework to forward
>>> the USB cable state information to the USB driver so the
>>> controller can be configured in the right mode (host/peripheral).
>>>
>>> Gets USB peripheral mode to work on this EVM.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>
>> on subject: x14 ? other than that

oops :P

>>
>> Reviewed-by: Felipe Balbi <balbi@ti.com>
> 
> Applying into omap-for-v4.1/dt-v2 with the subject line fixed.

Thanks Tony.

cheers,
-roger

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-18  9:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17  9:43 [PATCH] ARM: dts: dra7x-evm: beagle-x14: Fix USB Peripheral Roger Quadros
2015-03-17 14:54 ` Felipe Balbi
2015-03-17 18:02   ` Tony Lindgren
2015-03-18  9:38     ` Roger Quadros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).