From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 3/4 v4] mailbox: Enable BCM2835 mailbox support Date: Wed, 18 Mar 2015 08:42:55 +0000 Message-ID: <20150318084255.GJ3318@x1> References: <1426213936-4139-1-git-send-email-eric@anholt.net> <1426213936-4139-3-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1426213936-4139-3-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Stephen Warren , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jassi Brar , Craig McGeachie , Lubomir Rintel , Suman Anna List-Id: devicetree@vger.kernel.org On Thu, 12 Mar 2015, Eric Anholt wrote: > From: Lubomir Rintel > > Implement BCM2835 mailbox support as a device registered with the > general purpose mailbox framework. Implementation based on commits by > Lubomir Rintel [1], Suman Anna and Jassi Brar [2] on which to base the > implementation. > > [1] http://lists.infradead.org/pipermail/linux-rpi-kernel/2013-April/000528.html > [2] http://lists.infradead.org/pipermail/linux-rpi-kernel/2013-May/000546.html > > Signed-off-by: Lubomir Rintel > Signed-off-by: Craig McGeachie > Signed-off-by: Suman Anna > Signed-off-by: Jassi Brar > Signed-off-by: Eric Anholt > Cc: Jassi Brar > Acked-by: Lee Jones > --- > > > v2: Squashed Craig's work for review, carried over to new version of > Mailbox framework (changes by Lubomir) > > v3: Fix multi-line comment style. Refer to the documentation by > filename. Only declare one MODULE_AUTHOR. Alphabetize includes. > Drop some excessive dev_dbg()s (changes by anholt). > > v4: Use the new bcm2835_peripheral_read_workaround(), drop the Can you explain to me why this is required (and don't just point me in the direction of the other patch ;) ). You appear to be using the non-relaxed variants of readl and writel, which already do memory barriers, so I'm a little perplexed as to how the problem can arise. > unnecessary wmb()s, make the messages be a pointer to u32, rather > than u32-cast-as-pointer, fold in small static functions, drop > extra error messages, clean up sizeof() arg for malloc, disable > interrupts on unload. > > drivers/mailbox/Kconfig | 8 ++ > drivers/mailbox/Makefile | 2 + > drivers/mailbox/bcm2835-mailbox.c | 259 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 269 insertions(+) > create mode 100644 drivers/mailbox/bcm2835-mailbox.c -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html