From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Bob Feretich
<bob.feretich-8wbKi1faPaosQv5ZqcSHkQ@public.gmane.org>,
Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: busses with dynamic ids should start after fixed ids for DT
Date: Wed, 18 Mar 2015 13:46:53 +0100 [thread overview]
Message-ID: <20150318124653.GC3580@katana> (raw)
In-Reply-To: <1426177093-26820-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Thu, Mar 12, 2015 at 05:17:59PM +0100, Wolfram Sang wrote:
> Make sure dynamic ids do not interfere with fixed ones and let them
> start after the highest fixed id. This patch might cause different
> bus-numbers for dynamic ids, however it fixes a bug. Assume:
>
> - fixed id0 defers probe
> - fixed id1 succeeds and registers a muxed bus with dynamic id
> - muxed bus gets id0
> - fixed id0 wants to probe again, but its fixed id is gone now
> - fixed id0 probe fails
>
> With this patch, the fixed ids are always reserved in the DT case.
> For legacy board init, we already have a mechanism like this in
> i2c_register_board_info().
>
> Reported-by: Bob Feretich <bob.feretich-8wbKi1faPaosQv5ZqcSHkQ@public.gmane.org>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Fixed the checkpatch warning and applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-18 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 16:17 [PATCH 0/2] i2c: prevent id collisions in the DT case Wolfram Sang
[not found] ` <1426177093-26820-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-12 16:17 ` [PATCH 1/2] of: base: add function to get highest id of an alias stem Wolfram Sang
2015-03-12 21:35 ` Rob Herring
[not found] ` <1426177093-26820-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-18 12:46 ` Wolfram Sang
2015-03-28 13:20 ` Grant Likely
2015-03-12 16:17 ` [PATCH 2/2] i2c: busses with dynamic ids should start after fixed ids for DT Wolfram Sang
[not found] ` <1426177093-26820-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-03-18 12:46 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318124653.GC3580@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=bob.feretich-8wbKi1faPaosQv5ZqcSHkQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).