From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] add support for Freescale's MMA8653FC 10 bit accelerometer Date: Wed, 18 Mar 2015 09:44:54 -0700 Message-ID: <20150318164454.GA11350@dtor-ws> References: <1426694157-10866-1-git-send-email-martink@posteo.de> <2231139.ojeyer6qnI@ws-stein> <5509AAE5.1000503@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5509AAE5.1000503@posteo.de> Sender: linux-input-owner@vger.kernel.org To: Martin Kepplinger Cc: Alexander Stein , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, linux-api@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kepplinger , Christoph Muellner List-Id: devicetree@vger.kernel.org On Wed, Mar 18, 2015 at 05:42:13PM +0100, Martin Kepplinger wrote: > Am 2015-03-18 um 17:21 schrieb Alexander Stein: > > On Wednesday 18 March 2015 16:55:57, Martin Kepplinger wrote: > >> From: Martin Kepplinger > >> > >> The MMA8653FC is a low-power, three-axis, capacitive micromachined > >> accelerometer with 10 bits of resolution with flexible user-programmable > >> options. > >> > >> Embedded interrupt functions enable overall power savings, by relieving the > >> host processor from continuously polling data, for example using the poll() > >> system call. > >> > >> The device can be configured to generate wake-up interrupt signals from any > >> combination of the configurable embedded functions, enabling the MMA8653FC > >> to monitor events while remaining in a low-power mode during periods of > >> inactivity. > >> > >> This driver provides devicetree properties to program the device's behaviour > >> and a simple, tested and documented sysfs interface. The data sheet and more > >> information is available on Freescale's website. > >> > >> Signed-off-by: Martin Kepplinger > >> Signed-off-by: Christoph Muellner > >> --- > >> applies to v4.0-rc4 and the current -next. > >> > >> patch revision history > >> ...................... > >> v2 corrects licensing and commit messages and adds appropriate recipients > >> > >> .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc | 39 + > >> .../devicetree/bindings/misc/fsl,mma8653fc.txt | 96 +++ > >> MAINTAINERS | 5 + > >> drivers/input/misc/Kconfig | 11 + > >> drivers/input/misc/Makefile | 1 + > >> drivers/input/misc/mma8653fc.c | 913 +++++++++++++++++++++ > >> 6 files changed, 1065 insertions(+) > >> create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc > >> create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt > >> create mode 100644 drivers/input/misc/mma8653fc.c > > > > Shouldn't this go to drivers/iio/magnetometer instead of defining a new sysfs ABI? > > > > It could have gone to drivers/iio/accel if it would use an iio > interface, which would make more sense, you are right, but I simply > don't have the time to merge it in to iio. > > It doesn't use an input interface either but I don't see a good place > for an accelerometer that uses sysfs only. drivers/misc? Since it is not using input infrastructure (nor should it), it does not belong in drivers/input. Thanks. -- Dmitry