devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] irqchip: renesas-irqc: Add functional clock to bindings
Date: Thu, 19 Mar 2015 10:41:44 +0900	[thread overview]
Message-ID: <20150319014143.GI14051@verge.net.au> (raw)
In-Reply-To: <1426704961-27322-4-git-send-email-geert+renesas@glider.be>

On Wed, Mar 18, 2015 at 07:55:57PM +0100, Geert Uytterhoeven wrote:
> The external IRQ controller has a functional clock, which is used for
> power management. Document it.
> 
> Fix a typo in the r8a73a4 SoC name while we're at it.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  .../devicetree/bindings/interrupt-controller/renesas,irqc.txt         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.txt b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.txt
> index 1a88e62228e59631..4f85aeb658e4c833 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.txt
> @@ -4,7 +4,7 @@ Required properties:
>  
>  - compatible: has to be "renesas,irqc-<soctype>", "renesas,irqc" as fallback.
>    Examples with soctypes are:
> -    - "renesas,irqc-r8a73a4" (R-Mobile AP6)
> +    - "renesas,irqc-r8a73a4" (R-Mobile APE6)
>      - "renesas,irqc-r8a7790" (R-Car H2)
>      - "renesas,irqc-r8a7791" (R-Car M2-W)
>      - "renesas,irqc-r8a7792" (R-Car V2H)
> @@ -12,6 +12,7 @@ Required properties:
>      - "renesas,irqc-r8a7794" (R-Car E2)
>  - #interrupt-cells: has to be <2>: an interrupt index and flags, as defined in
>    interrupts.txt in this directory
> +- clocks: Must contain a reference to the functional clock.
>  
>  Optional properties:
>  
> @@ -29,4 +30,5 @@ Example:
>  			     <0 1 IRQ_TYPE_LEVEL_HIGH>,
>  			     <0 2 IRQ_TYPE_LEVEL_HIGH>,
>  			     <0 3 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp4_clks R8A7790_CLK_IRQC>;
>  	};
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-03-19  1:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 18:55 [PATCH 0/7] ARM: shmobile: Add IRQC clock to device tree Geert Uytterhoeven
2015-03-18 18:55 ` [PATCH 1/7] irqchip: renesas-irqc: Add more register documentation Geert Uytterhoeven
     [not found]   ` <1426704961-27322-2-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-03-19  1:36     ` Simon Horman
2015-03-18 18:55 ` [PATCH 2/7] irqchip: renesas-irqc: Add minimal runtime PM support Geert Uytterhoeven
     [not found]   ` <1426704961-27322-3-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-03-19  1:37     ` Simon Horman
     [not found] ` <1426704961-27322-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-03-18 18:55   ` [PATCH 3/7] irqchip: renesas-irqc: Add functional clock to bindings Geert Uytterhoeven
2015-03-19  1:41     ` Simon Horman [this message]
2015-03-18 18:55 ` [PATCH 4/7] ARM: shmobile: r8a7734: Add IRQC clock to device tree Geert Uytterhoeven
2015-03-18 18:55 ` [PATCH 5/7] ARM: shmobile: r8a7790: " Geert Uytterhoeven
2015-03-18 18:56 ` [PATCH 6/7] ARM: shmobile: r8a7791: " Geert Uytterhoeven
2015-03-18 18:56 ` [PATCH 7/7] ARM: shmobile: r8a7794: " Geert Uytterhoeven
2015-03-19  1:43 ` [PATCH 0/7] ARM: shmobile: " Simon Horman
     [not found]   ` <20150319014328.GJ14051-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-04-27 14:15     ` Geert Uytterhoeven
2015-04-28  0:52       ` Simon Horman
2015-03-23 10:09 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319014143.GI14051@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).