From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 2/2] i2c: driver for the Conexant Digicolor I2C controller
Date: Thu, 19 Mar 2015 13:15:33 +0200 [thread overview]
Message-ID: <20150319111533.GF2415@tarshish> (raw)
In-Reply-To: <20150319110002.GD914@katana>
Hi Wolfram,
On Thu, Mar 19, 2015 at 12:00:02PM +0100, Wolfram Sang wrote:
> On Thu, Mar 19, 2015 at 11:54:18AM +0200, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> > ---
> > v2:
> > * Address the comment of Wolfram Sang:
> > - Advertise the I2C_FUNC_NOSTART capability
> > - Rebase on v4.0-rc1
>
> Please fix:
>
> Applying: i2c: driver for the Conexant Digicolor I2C controller
> CHECKPATCH
> ...
>
> ERROR: code indent should use tabs where possible
> #119: FILE: drivers/i2c/busses/i2c-digicolor.c:68:
> + STATE_IDLE,$
Sorry. I should have caught these earlier. Will fix.
[...]
> There are more checkpatch warnings I don't care about much.
> You can decide about them.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-03-19 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 9:54 [PATCH v2 1/2] i2c: dt binding documentation for the Digicolor I2C controller Baruch Siach
[not found] ` <844001df525b3073e50cbd95f357c0eb9912a394.1426758858.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2015-03-19 9:54 ` [PATCH v2 2/2] i2c: driver for the Conexant " Baruch Siach
[not found] ` <866aada336ddbeec18749a1c301ab9b365baadde.1426758858.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2015-03-19 11:00 ` Wolfram Sang
2015-03-19 11:15 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319111533.GF2415@tarshish \
--to=baruch-nswtu9s1w3p6gbpvegmw2w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).