From: Grant Likely <grant.likely@secretlab.ca>
To: Rob Herring <robherring2@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Wolfram Sang <wsa@the-dreams.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pantelis Antoniou <panto@antoniou-consulting.com>
Subject: Re: [PATCH] of: Empty node & property flag accessors when !OF
Date: Fri, 20 Mar 2015 12:12:23 +0000 [thread overview]
Message-ID: <20150320121223.16D69C4076B@trevor.secretlab.ca> (raw)
In-Reply-To: <CAL_JsqKxtJH=JyruyuMLXSFfTLdswOLa=AfGEbROsSSOhLLDkg@mail.gmail.com>
On Thu, 22 Jan 2015 17:13:51 -0600
, Rob Herring <robherring2@gmail.com>
wrote:
> +Wolfram
>
> On Wed, Jan 21, 2015 at 11:05 AM, Pantelis Antoniou
> <pantelis.antoniou@konsulko.com> wrote:
> > Introduce empty node and property flag accessors when CONFIG_OF is not
> > defined.
> > This allows us to use them without ifdef'ing them in places where it
> > makes sense to do so.
> >
> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> I've asked Wolfram to apply. While not a fix itself, this is needed
> for an I2C related fix for 3.19.
I don't see this in mainline or linux-next, so I've applied to my tree.
Thanks.
g.
>
> Rob
>
> > ---
> > include/linux/of.h | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index dfde07e..7ede449 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -616,6 +616,38 @@ static inline const char *of_prop_next_string(struct property *prop,
> > return NULL;
> > }
> >
> > +static inline int of_node_check_flag(struct device_node *n, unsigned long flag)
> > +{
> > + return 0;
> > +}
> > +
> > +static inline int of_node_test_and_set_flag(struct device_node *n,
> > + unsigned long flag)
> > +{
> > + return 0;
> > +}
> > +
> > +static inline void of_node_set_flag(struct device_node *n, unsigned long flag)
> > +{
> > +}
> > +
> > +static inline void of_node_clear_flag(struct device_node *n, unsigned long flag)
> > +{
> > +}
> > +
> > +static inline int of_property_check_flag(struct property *p, unsigned long flag)
> > +{
> > + return 0;
> > +}
> > +
> > +static inline void of_property_set_flag(struct property *p, unsigned long flag)
> > +{
> > +}
> > +
> > +static inline void of_property_clear_flag(struct property *p, unsigned long flag)
> > +{
> > +}
> > +
> > #define of_match_ptr(_ptr) NULL
> > #define of_match_node(_matches, _node) NULL
> > #endif /* CONFIG_OF */
> > --
> > 1.7.12
> >
next prev parent reply other threads:[~2015-03-20 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 17:05 [PATCH] of: Empty node & property flag accessors when !OF Pantelis Antoniou
[not found] ` <1421859957-24457-1-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-01-22 23:13 ` Rob Herring
2015-03-20 12:12 ` Grant Likely [this message]
[not found] ` <20150320121223.16D69C4076B-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2015-03-22 21:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320121223.16D69C4076B@trevor.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=panto@antoniou-consulting.com \
--cc=robherring2@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).