From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Andy Gross <agross@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Ohad Ben-Cohen <ohad@wizery.com>,
Kumar Gala <galak@codeaurora.org>, Suman Anna <s-anna@ti.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex
Date: Fri, 20 Mar 2015 13:49:12 -0700 [thread overview]
Message-ID: <20150320204912.GC31953@sonymobile.com> (raw)
In-Reply-To: <20150320202909.GA8189@qualcomm.com>
On Fri 20 Mar 13:29 PDT 2015, Andy Gross wrote:
> On Thu, Mar 19, 2015 at 06:48:10PM -0700, Bjorn Andersson wrote:
>
> <snip>
>
> > +Example:
> > +
> > + tcsr: syscon@1a400000 {
>
> typo here, syscon@fd484000. And this syscon is specifically for the tcsr mutex
> reg area.
>
You're right, I didn't read the documentation good enough; let's name it
tcsr-mutex and as this is not the main tcsr region we should fall back
to just having syscon as compatible.
But there's still a bunch of other registers in the tcsr-mutex range -
that probably will be consumed by various drivers, so it still makes
sense to have a syscon there.
Sorry about the address, will update that as well.
> > + compatible = "qcom,tcsr-msm8974", "syscon";
> > + reg = <0xfd484000 0x2000>;
>
Regards,
Bjorn
next prev parent reply other threads:[~2015-03-20 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 1:48 [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex Bjorn Andersson
2015-03-20 20:29 ` Andy Gross
2015-03-20 20:49 ` Bjorn Andersson [this message]
2015-03-20 21:42 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320204912.GC31953@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).