devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"robherring2@gmail.com" <robherring2@gmail.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"lina.iyer@linaro.org" <lina.iyer@linaro.org>,
	"sboyd@codeaurora.org" <sboyd@codeaurora.org>
Subject: Re: [PATCH V3 5/8] ARM64: cpuidle: Remove arm64 reference
Date: Sat, 21 Mar 2015 20:21:33 +0000	[thread overview]
Message-ID: <20150321202133.GC22354@red-moon> (raw)
In-Reply-To: <1426851841-2072-6-git-send-email-daniel.lezcano@linaro.org>

On Fri, Mar 20, 2015 at 11:43:58AM +0000, Daniel Lezcano wrote:
> In the next patch, this driver will be common across ARM/ARM64. Remove all refs
> to ARM64 as it will be shared with ARM32.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Kevin Hilman <khilman@linaro.org>
> Acked-by: Rob Herring <robherring2@gmail.com>

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> ---
>  drivers/cpuidle/cpuidle-arm64.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c
> index 6ef291c7..1c94b88 100644
> --- a/drivers/cpuidle/cpuidle-arm64.c
> +++ b/drivers/cpuidle/cpuidle-arm64.c
> @@ -1,5 +1,5 @@
>  /*
> - * ARM64 generic CPU idle driver.
> + * ARM/ARM64 generic CPU idle driver.
>   *
>   * Copyright (C) 2014 ARM Ltd.
>   * Author: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> @@ -9,7 +9,7 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#define pr_fmt(fmt) "CPUidle arm64: " fmt
> +#define pr_fmt(fmt) "CPUidle arm: " fmt
>  
>  #include <linux/cpuidle.h>
>  #include <linux/cpumask.h>
> @@ -23,7 +23,7 @@
>  #include "dt_idle_states.h"
>  
>  /*
> - * arm64_enter_idle_state - Programs CPU to enter the specified state
> + * arm_enter_idle_state - Programs CPU to enter the specified state
>   *
>   * dev: cpuidle device
>   * drv: cpuidle driver
> @@ -32,8 +32,8 @@
>   * Called from the CPUidle framework to program the device to the
>   * specified target state selected by the governor.
>   */
> -static int arm64_enter_idle_state(struct cpuidle_device *dev,
> -				  struct cpuidle_driver *drv, int idx)
> +static int arm_enter_idle_state(struct cpuidle_device *dev,
> +				struct cpuidle_driver *drv, int idx)
>  {
>  	int ret;
>  
> @@ -57,8 +57,8 @@ static int arm64_enter_idle_state(struct cpuidle_device *dev,
>  	return ret ? -1 : idx;
>  }
>  
> -static struct cpuidle_driver arm64_idle_driver = {
> -	.name = "arm64_idle",
> +static struct cpuidle_driver arm_idle_driver = {
> +	.name = "arm_idle",
>  	.owner = THIS_MODULE,
>  	/*
>  	 * State at index 0 is standby wfi and considered standard
> @@ -68,32 +68,32 @@ static struct cpuidle_driver arm64_idle_driver = {
>  	 * handler for idle state index 0.
>  	 */
>  	.states[0] = {
> -		.enter                  = arm64_enter_idle_state,
> +		.enter                  = arm_enter_idle_state,
>  		.exit_latency           = 1,
>  		.target_residency       = 1,
>  		.power_usage		= UINT_MAX,
>  		.name                   = "WFI",
> -		.desc                   = "ARM64 WFI",
> +		.desc                   = "ARM WFI",
>  	}
>  };
>  
> -static const struct of_device_id arm64_idle_state_match[] __initconst = {
> +static const struct of_device_id arm_idle_state_match[] __initconst = {
>  	{ .compatible = "arm,idle-state",
> -	  .data = arm64_enter_idle_state },
> +	  .data = arm_enter_idle_state },
>  	{ },
>  };
>  
>  /*
> - * arm64_idle_init
> + * arm_idle_init
>   *
> - * Registers the arm64 specific cpuidle driver with the cpuidle
> + * Registers the arm specific cpuidle driver with the cpuidle
>   * framework. It relies on core code to parse the idle states
>   * and initialize them using driver data structures accordingly.
>   */
> -static int __init arm64_idle_init(void)
> +static int __init arm_idle_init(void)
>  {
>  	int cpu, ret;
> -	struct cpuidle_driver *drv = &arm64_idle_driver;
> +	struct cpuidle_driver *drv = &arm_idle_driver;
>  
>  	/*
>  	 * Initialize idle states data, starting at index 1.
> @@ -101,7 +101,7 @@ static int __init arm64_idle_init(void)
>  	 * let the driver initialization fail accordingly since there is no
>  	 * reason to initialize the idle driver if only wfi is supported.
>  	 */
> -	ret = dt_init_idle_driver(drv, arm64_idle_state_match, 1);
> +	ret = dt_init_idle_driver(drv, arm_idle_state_match, 1);
>  	if (ret <= 0)
>  		return ret ? : -ENODEV;
>  
> @@ -119,4 +119,4 @@ static int __init arm64_idle_init(void)
>  
>  	return cpuidle_register(drv, NULL);
>  }
> -device_initcall(arm64_idle_init);
> +device_initcall(arm_idle_init);
> -- 
> 1.9.1
> 
> 

  reply	other threads:[~2015-03-21 20:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 11:43 [PATCH V3 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach Daniel Lezcano
2015-03-20 11:43 ` [PATCH V3 2/8] ARM: cpuidle: Add a cpuidle ops structure to be used for DT Daniel Lezcano
2015-03-25 21:34   ` Stephen Boyd
2015-03-20 11:43 ` [PATCH V3 3/8] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function Daniel Lezcano
2015-03-20 11:43 ` [PATCH V3 4/8] ARM64: cpuidle: Rename cpu_init_idle to a common function name Daniel Lezcano
2015-03-21 20:24   ` Lorenzo Pieralisi
2015-03-20 11:43 ` [PATCH V3 5/8] ARM64: cpuidle: Remove arm64 reference Daniel Lezcano
2015-03-21 20:21   ` Lorenzo Pieralisi [this message]
     [not found] ` <1426851841-2072-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-20 11:43   ` [PATCH V3 1/8] ARM: cpuidle: Remove duplicate header inclusion Daniel Lezcano
2015-03-20 11:43   ` [PATCH V3 6/8] ARM: cpuidle: Enable the ARM64 driver for both ARM32/ARM64 Daniel Lezcano
2015-03-21 20:20     ` Lorenzo Pieralisi
2015-03-20 11:44 ` [PATCH V3 7/8] ARM: cpuidle: Register per cpuidle device Daniel Lezcano
2015-03-21 20:35   ` Lorenzo Pieralisi
2015-03-23 14:42     ` Daniel Lezcano
2015-03-23 15:41     ` Daniel Lezcano
2015-03-23 16:25       ` Lorenzo Pieralisi
2015-03-23 16:50         ` [PATCH V4] " Daniel Lezcano
2015-03-23 22:58           ` Lorenzo Pieralisi
2015-03-24  9:54             ` [PATCH V5 1/2] " Daniel Lezcano
2015-03-24  9:54               ` [PATCH 2/2] ARM: cpuidle: Document the code Daniel Lezcano
2015-03-24 18:51                 ` Lorenzo Pieralisi
2015-03-24 19:04                   ` Lorenzo Pieralisi
2015-03-25  7:03                   ` Daniel Lezcano
2015-03-24 18:10               ` [PATCH V5 1/2] ARM: cpuidle: Register per cpuidle device Lorenzo Pieralisi
2015-03-20 11:44 ` [PATCH V3 8/8] ARM: cpuidle: Change function name to be consistent with x86 Daniel Lezcano
2015-03-21 20:09   ` Lorenzo Pieralisi
2015-03-20 18:31 ` [PATCH V3 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach Lorenzo Pieralisi
2015-03-20 18:39   ` Daniel Lezcano
2015-03-21 20:51 ` Lorenzo Pieralisi
2015-03-23 15:27 ` Lorenzo Pieralisi
2015-03-23 15:31   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150321202133.GC22354@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robherring2@gmail.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).