From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v5 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx. Date: Mon, 23 Mar 2015 09:45:05 +0100 Message-ID: <20150323084505.GH9742@pengutronix.de> References: <1426917922-61356-1-git-send-email-eddie.huang@mediatek.com> <1426917922-61356-2-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1426917922-61356-2-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eddie Huang Cc: Wolfram Sang , Matthias Brugger , Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= , Mark Rutland , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Box , Lee Jones , Jean Delvare , Xudong Chen , Boris BREZILLON , Arnd Bergmann , Liguo Zhang , Wei Yan , Bjorn Andersson , Neelesh Gupta , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , Beniamino Galvani , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm- List-Id: devicetree@vger.kernel.org On Sat, Mar 21, 2015 at 02:05:20PM +0800, Eddie Huang wrote: > From: Xudong Chen > > Add devicetree bindings for Mediatek Soc I2C driver. > > Signed-off-by: Xudong Chen > Signed-off-by: Eddie Huang > --- > .../devicetree/bindings/i2c/i2c-mt6577.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > new file mode 100644 > index 0000000..eff52c1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > @@ -0,0 +1,41 @@ > +* Mediatek's I2C controller > + > +The Mediatek's I2C controller is used to interface with I2C devices. > + > +Required properties: > + - compatible: value should be either of the following. > + (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c. > + (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c. > + (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c. > + (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c. > + (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c. > + - reg: physical base address of the controller and dma base, length of memory > + mapped region. > + - interrupts: interrupt number to the cpu. > + - clock-div: the fixed value for frequency divider of clock source in i2c > + module. Each IC may be different. > + - clocks: clock name from clock manager > + - clock-names: Must include "main" and "dma", if enable have-pmic need include > + "pmic" extra. > + > +Optional properties: > + - clock-frequency: Frequency in Hz of the bus when transfer, the default value > + is 100000. > + - mediatek,have-pmic: platform can control i2c form special pmic side. > + Only mt6589 and mt8135 support this feature. > + - mediatek,use-push-pull: IO config use push-pull mode. > + > +Example: > + > + i2c0: i2c@1100d000 { > + compatible = "mediatek,mt6577-i2c"; > + reg = <0x1100d000 0x70>, > + <0x11000300 0x80>; > + interrupts = ; > + clock-frequency = <100000>; Since 100000 is the default you should probably pick another speed for this example or drop the property. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |