From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: vinod.koul@intel.com, tony@atomide.com, grant.likely@linaro.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
nm@ti.com
Subject: Re: [PATCH v3 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests
Date: Fri, 27 Mar 2015 20:22:30 +0000 [thread overview]
Message-ID: <20150327202230.GA4027@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1427459213-14611-7-git-send-email-peter.ujfalusi@ti.com>
On Fri, Mar 27, 2015 at 02:26:52PM +0200, Peter Ujfalusi wrote:
> Do not direct map the virtual channels to sDMA request number. When the
> sDMA is behind of a crossbar this direct mapping can cause situations when
> certain channel can not be requested since the crossbar request number
> will no longer match with the sDMA request line.
> The direct mapping for virtual channels with HW request lines will make it
> harder to implement MEM_TO_MEM mode for the driver.
There's no point having 127 virtual DMA channels then... is there?
We might as well reduce the number down to a more reasonable set
rather than wasting memory.
> @@ -1049,7 +1050,6 @@ static int omap_dma_chan_init(struct omap_dmadev *od, int dma_sig)
> return -ENOMEM;
>
> c->reg_map = od->reg_map;
> - c->dma_sig = dma_sig;
That's the only user of dma_sig in this function. Why not remove it from
the function prototype and its caller?
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-03-27 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 12:26 [PATCH v3 0/7] dmaengine/dra7x: DMA router (crossbar support) Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 1/7] dmaengine: of_dma: Support for DMA routers Peter Ujfalusi
2015-03-28 1:44 ` Arnd Bergmann
2015-03-31 16:48 ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 2/7] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 4/7] dmaengine: omap-dma: Use defines for dma channels and request count Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available Peter Ujfalusi
2015-03-27 20:24 ` Russell King - ARM Linux
2015-03-31 14:47 ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests Peter Ujfalusi
2015-03-27 20:22 ` Russell King - ARM Linux [this message]
2015-03-31 15:44 ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 7/7] ARM: DTS: dra7x: Integrate sDMA crossbar Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327202230.GA4027@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).