From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH RFC] ARM: BCM5301X: Add /device_id property including device ID string Date: Mon, 30 Mar 2015 11:37:00 +0100 Message-ID: <20150330103659.GD17971@leverpostej> References: <1427667288-23903-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1427667288-23903-1-git-send-email-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Hauke Mehrtens , Florian Fainelli , Russell King , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, =46or DT patches, please send to devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; this affec= ts more than just ARM. On Sun, Mar 29, 2015 at 11:14:48PM +0100, Rafa=C5=82 Mi=C5=82ecki wrote= : > Device vendors often assign IDs to their devices to allow comparing > firmware image with device model. This is required to prevent users > from flashing incompatible image and soft-bricking device. > Add device_id property to DTs to allow user space (and optionally > bootloader) verifying firmware images. This sounds like exactly what the "model" property is meant to be (per ePAPR) -- a string that specifices the manufacturer's model number of the device, ideally in "manufacturer,model" format. >=20 > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > --- > Hi guys, >=20 > I think my commit message explains pretty well what I'm trying to do, > however I'm not sure if I'm using a right place for that. > I also didn't document this news property, as I can't find a place > where root-properties are currenty described. Is there any such place= ? > I couldn't find a file describing e.g. "model" property. It's documented in ePAPR (embedded power achitecture platform requirements), and possibly earlier device tree and/or open firmware documents. Unfortuantely ePAPR is now behind a registration page on power.org, and I'm not sure where most other documents live (playground.sun.com and other sources are dead). Mark. > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts | 1 + > arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 1 + > arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 1 + > arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts | 1 + > arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 1 + > 5 files changed, 5 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts b/arch/arm/b= oot/dts/bcm4708-asus-rt-ac68u.dts > index 8b62836..9d2fac4 100644 > --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > @@ -14,6 +14,7 @@ > / { > compatible =3D "asus,rt-ac68u", "brcm,bcm4708"; > model =3D "Asus RT-AC68U (BCM4708)"; > + device_id =3D "RT-AC68U"; > =20 > chosen { > bootargs =3D "console=3DttyS0,115200"; > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/b= oot/dts/bcm4708-netgear-r6250.dts > index 2ed9e57..98c8d63 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > @@ -14,6 +14,7 @@ > / { > compatible =3D "netgear,r6250v1", "brcm,bcm4708"; > model =3D "Netgear R6250 V1 (BCM4708)"; > + device_id =3D "U12H245T00_NETGEAR"; > =20 > chosen { > bootargs =3D "console=3DttyS0,115200"; > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/ar= m/boot/dts/bcm4708-netgear-r6300-v2.dts > index 3991042..c43173a 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > @@ -14,6 +14,7 @@ > / { > compatible =3D "netgear,r6300v2", "brcm,bcm4708"; > model =3D "Netgear R6300 V2 (BCM4708)"; > + device_id =3D "U12H240T00_NETGEAR"; > =20 > chosen { > bootargs =3D "console=3DttyS0,115200"; > diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/b= oot/dts/bcm47081-asus-rt-n18u.dts > index 0ee85ea..876e2c0 100644 > --- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > +++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > @@ -14,6 +14,7 @@ > / { > compatible =3D "asus,rt-n18u", "brcm,bcm47081", "brcm,bcm4708"; > model =3D "Asus RT-N18U (BCM47081)"; > + device_id =3D "RT-N18U"; > =20 > chosen { > bootargs =3D "console=3DttyS0,115200"; > diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/b= oot/dts/bcm4709-netgear-r8000.dts > index ea26dd3..129df9a 100644 > --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > @@ -14,6 +14,7 @@ > / { > compatible =3D "netgear,r8000", "brcm,bcm4709", "brcm,bcm4708"; > model =3D "Netgear R8000 (BCM4709)"; > + device_id =3D "U12H315T00_NETGEAR"; > =20 > chosen { > bootargs =3D "console=3DttyS0,115200"; > --=20 > 1.8.4.5 >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html