From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc
Date: Tue, 31 Mar 2015 10:12:04 +0200 [thread overview]
Message-ID: <20150331081204.GH3849@piout.net> (raw)
In-Reply-To: <5519EE93.70509@samsung.com>
On 31/03/2015 at 09:47:15 +0900, Chanwoo Choi wrote :
> > Are you absolutely sure that the exynos3250 IP is the same as the
> > s3c6410 (I don't know much about the exynos family). The concern being
> > that if at one point you have an errata on one or ther other, you will
> > have to break the DT ABI by undoing this change.
> >
> > Note that I'm fine with it, I'm just asking.
>
> I'm sure about exynos3250 RTC is same with S3C6410 RTC.
> There was little different about that pevious S3C6410 RTC
> don't consider to control the 'rtc_src' clk.
>
>
> But, Javier's patch[1] add the '.needs_src_clk' to control the
> 'rtc_src' clk. After merged this patch, there is no different part between
> Exynos3250 RTC and S3C6410 RTC.
>
> [1] 8792f7772f4f (drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data)
>
Yes, I saw that the software was handling both the same way, I was
asking about the hardware side.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-31 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 15:19 [PATCH 0/2] ARM: EXYNOS: Minor S3C RTC cleanups Krzysztof Kozlowski
2015-03-30 15:19 ` [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410 Krzysztof Kozlowski
2015-03-30 23:37 ` Chanwoo Choi
2015-03-31 0:27 ` Alexandre Belloni
[not found] ` <20150331002709.GF3849-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-03-31 6:49 ` Javier Martinez Canillas
2015-03-31 8:20 ` Alexandre Belloni
[not found] ` <20150331082052.GI3849-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-03-31 9:00 ` [rtc-linux] " Krzysztof Kozlowski
2015-03-30 15:19 ` [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc Krzysztof Kozlowski
2015-03-30 23:38 ` Chanwoo Choi
2015-03-31 0:31 ` Alexandre Belloni
2015-03-31 0:47 ` Chanwoo Choi
2015-03-31 8:12 ` Alexandre Belloni [this message]
2015-03-31 8:56 ` [rtc-linux] " Krzysztof Kozlowski
2015-03-31 6:43 ` Javier Martinez Canillas
2015-03-31 6:54 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331081204.GH3849@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).