From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. Date: Tue, 31 Mar 2015 11:29:58 -0400 Message-ID: <20150331152958.GF9974@htj.duckdns.org> References: <1427787309-1601-1-git-send-email-peter.griffin@linaro.org> <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-ide@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > Acked-by: Maxime Coquelin How should this patch be routed? Should I pick this up and apply to libata/for-4.1 or should it go together with the other patches? If the latter, please feel free to add my acked-by. Thanks. -- tejun