[PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

This patch adds nodes for the Goodix GT911 touchscreen controller found
on the Wexler TAB7200 tablet. Controller uses one of following I2C
addresses: 0x5d or 0x14, so just add two nodes.

Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
DT support for the Goodix GT911 touchscreen controller has been queued up
by Dmitry Torokhov for merging into 4.1:
https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329

IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE.

 arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 2ad3b09..34e2bce 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -101,6 +101,20 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2_pins_a>;
 	status = "okay";
+
+	gt911@5d {
+		compatible = "goodix,gt911";
+		reg = <0x5d>;
+		interrupt-parent = <&pio>;
+		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
+	};
+
+	gt911@14 {
+		compatible = "goodix,gt911";
+		reg = <0x14>;
+		interrupt-parent = <&pio>;
+		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
+	};
 };
 
 &lradc {
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2033 bytes --]

Hi,

On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> This patch adds nodes for the Goodix GT911 touchscreen controller found
> on the Wexler TAB7200 tablet. Controller uses one of following I2C
> addresses: 0x5d or 0x14, so just add two nodes.

In which case are these different addresses encountered? Different
revisions of the same board?

> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> DT support for the Goodix GT911 touchscreen controller has been queued up
> by Dmitry Torokhov for merging into 4.1:
> https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329
> 
> IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE.
> 
>  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 2ad3b09..34e2bce 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -101,6 +101,20 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c2_pins_a>;
>  	status = "okay";
> +
> +	gt911@5d {

The node name should be the class of the device. touchscreen in this
case.

> +		compatible = "goodix,gt911";
> +		reg = <0x5d>;
> +		interrupt-parent = <&pio>;
> +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */

Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
bindings.

You're also not adding a pinctrl group for that pin?

> +	};
> +
> +	gt911@14 {
> +		compatible = "goodix,gt911";
> +		reg = <0x14>;
> +		interrupt-parent = <&pio>;
> +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> +	};

And nodes should be ordered by addresses ascending order.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

On Tue, 31 Mar 2015 07:43:38 -0700
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> Hi,
> 
> On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > addresses: 0x5d or 0x14, so just add two nodes.
> 
> In which case are these different addresses encountered? Different
> revisions of the same board?
> 
According to the datasheet it is a feature of the controller. 
The address(0x5d or 0x14) can be configured using a reset sequence,
which has not yet been implemented in the driver.
>
> > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > DT support for the Goodix GT911 touchscreen controller has been queued up
> > by Dmitry Torokhov for merging into 4.1:
> > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329
> > 
> > IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE.
> > 
> >  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > index 2ad3b09..34e2bce 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > @@ -101,6 +101,20 @@
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&i2c2_pins_a>;
> >  	status = "okay";
> > +
> > +	gt911@5d {
> 
> The node name should be the class of the device. touchscreen in this
> case.
> 
> > +		compatible = "goodix,gt911";
> > +		reg = <0x5d>;
> > +		interrupt-parent = <&pio>;
> > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> 
> Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> bindings.
> 
> You're also not adding a pinctrl group for that pin?
> 
> > +	};
> > +
> > +	gt911@14 {
> > +		compatible = "goodix,gt911";
> > +		reg = <0x14>;
> > +		interrupt-parent = <&pio>;
> > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > +	};
> 
> And nodes should be ordered by addresses ascending order.
> 
> Thanks!
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> On Tue, 31 Mar 2015 07:43:38 -0700
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > Hi,
> > 
> > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > addresses: 0x5d or 0x14, so just add two nodes.
> > 
> > In which case are these different addresses encountered? Different
> > revisions of the same board?
>
> According to the datasheet it is a feature of the controller. 
> The address(0x5d or 0x14) can be configured using a reset sequence,
> which has not yet been implemented in the driver.

Which address is set up by the bootloader then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

On Thu, 2 Apr 2015 11:22:59 +0200
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > On Tue, 31 Mar 2015 07:43:38 -0700
> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > 
> > > Hi,
> > > 
> > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > 
> > > In which case are these different addresses encountered? Different
> > > revisions of the same board?
> >
> > According to the datasheet it is a feature of the controller. 
> > The address(0x5d or 0x14) can be configured using a reset sequence,
> > which has not yet been implemented in the driver.
> 
> Which address is set up by the bootloader then?
> 
I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
For this we need nodes on both adresses.
>
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote:
> On Thu, 2 Apr 2015 11:22:59 +0200
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > > On Tue, 31 Mar 2015 07:43:38 -0700
> > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > > 
> > > > In which case are these different addresses encountered? Different
> > > > revisions of the same board?
> > >
> > > According to the datasheet it is a feature of the controller. 
> > > The address(0x5d or 0x14) can be configured using a reset sequence,
> > > which has not yet been implemented in the driver.
> > 
> > Which address is set up by the bootloader then?
>
> I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
> controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
> For this we need nodes on both adresses.

I'm confused, who changes that address then?

The controller itself?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

On Mon, 13 Apr 2015 18:09:51 +0200
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote:
> > On Thu, 2 Apr 2015 11:22:59 +0200
> > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > 
> > > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > > > On Tue, 31 Mar 2015 07:43:38 -0700
> > > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > > 
> > > > > Hi,
> > > > > 
> > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > > > 
> > > > > In which case are these different addresses encountered? Different
> > > > > revisions of the same board?
> > > >
> > > > According to the datasheet it is a feature of the controller. 
> > > > The address(0x5d or 0x14) can be configured using a reset sequence,
> > > > which has not yet been implemented in the driver.
> > > 
> > > Which address is set up by the bootloader then?
> >
> > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
> > controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
> > For this we need nodes on both adresses.
> 
> I'm confused, who changes that address then?
> 
> The controller itself?
> 
If I understood correctly, when device starts it sets reset pin (PB13) to
high level and int pin(PH21) to low level. After this int pin sets up as
external interrupt. This sequence triggers controller to use 0x5d address.

After hard reset both pins may be hight level and it triggers controller
to use 0x14 address.

Please see datasheets at pages 8-10.

https://drive.google.com/file/d/0BxCVOQS3ZymGdEE0cHI3bnp5WVE
https://drive.google.com/file/d/0BxCVOQS3ZymGbDAzVnZwZ2lOZ1E
>
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2529 bytes --]

On Mon, Apr 13, 2015 at 10:01:00PM +0300, Aleksei Mamlin wrote:
> On Mon, 13 Apr 2015 18:09:51 +0200
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote:
> > > On Thu, 2 Apr 2015 11:22:59 +0200
> > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > 
> > > > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > > > > On Tue, 31 Mar 2015 07:43:38 -0700
> > > > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > > > > 
> > > > > > In which case are these different addresses encountered? Different
> > > > > > revisions of the same board?
> > > > >
> > > > > According to the datasheet it is a feature of the controller. 
> > > > > The address(0x5d or 0x14) can be configured using a reset sequence,
> > > > > which has not yet been implemented in the driver.
> > > > 
> > > > Which address is set up by the bootloader then?
> > >
> > > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
> > > controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
> > > For this we need nodes on both adresses.
> > 
> > I'm confused, who changes that address then?
> > 
> > The controller itself?
> > 
> If I understood correctly, when device starts it sets reset pin (PB13) to
> high level and int pin(PH21) to low level. After this int pin sets up as
> external interrupt. This sequence triggers controller to use 0x5d address.
> 
> After hard reset both pins may be hight level and it triggers controller
> to use 0x14 address.
> 
> Please see datasheets at pages 8-10.
> 
> https://drive.google.com/file/d/0BxCVOQS3ZymGdEE0cHI3bnp5WVE
> https://drive.google.com/file/d/0BxCVOQS3ZymGbDAzVnZwZ2lOZ1E

If so, then the driver should be fixed to handle that power sequence
correctly and make sure that the device is using the 0x5d address,
whatever the previous state was.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

On Tue, 31 Mar 2015 07:43:38 -0700
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> Hi,
> 
> On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > addresses: 0x5d or 0x14, so just add two nodes.
> 
> In which case are these different addresses encountered? Different
> revisions of the same board?
> 
> > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > DT support for the Goodix GT911 touchscreen controller has been queued up
> > by Dmitry Torokhov for merging into 4.1:
> > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329
> > 
> > IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE.
> > 
> >  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > index 2ad3b09..34e2bce 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > @@ -101,6 +101,20 @@
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&i2c2_pins_a>;
> >  	status = "okay";
> > +
> > +	gt911@5d {
> 
> The node name should be the class of the device. touchscreen in this
> case.
> 
Ok, I'll fix it.
>
> > +		compatible = "goodix,gt911";
> > +		reg = <0x5d>;
> > +		interrupt-parent = <&pio>;
> > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> 
> Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> bindings.
> 
Hmm. Which value I must use in this case? IRQ type is set by the touchscreen controller driver, so I think that value must be 0.
>
> You're also not adding a pinctrl group for that pin?
>
No, because it works fine with this DT nodes. It seems that I should first configure pin to work in interrupt mode. Correct?
>
> > +	};
> > +
> > +	gt911@14 {
> > +		compatible = "goodix,gt911";
> > +		reg = <0x14>;
> > +		interrupt-parent = <&pio>;
> > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > +	};
> 
> And nodes should be ordered by addresses ascending order.
>
I'll fix it too.
>
> Thanks!
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > +		compatible = "goodix,gt911";
> > > +		reg = <0x5d>;
> > > +		interrupt-parent = <&pio>;
> > > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > 
> > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > bindings.
> > 
>
> Hmm. Which value I must use in this case? IRQ type is set by the
> touchscreen controller driver, so I think that value must be 0.

Whatever the hardware is using. Presumably the same value than the
driver sets.

> >
> > You're also not adding a pinctrl group for that pin?
>
> No, because it works fine with this DT nodes. It seems that I should
> first configure pin to work in interrupt mode. Correct?

You don't have to, since the pio driver will already take care of
muxing it to the right function, but that will prevent any driver to
call pinctrl_request on the same pin.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Aleksei Mamlin]

On Thu, 2 Apr 2015 20:50:08 +0200
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > > +		compatible = "goodix,gt911";
> > > > +		reg = <0x5d>;
> > > > +		interrupt-parent = <&pio>;
> > > > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > > 
> > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > > bindings.
> > > 
> >
> > Hmm. Which value I must use in this case? IRQ type is set by the
> > touchscreen controller driver, so I think that value must be 0.
> 
> Whatever the hardware is using. Presumably the same value than the
> driver sets.
> 
> > >
> > > You're also not adding a pinctrl group for that pin?
> >
> > No, because it works fine with this DT nodes. It seems that I should
> > first configure pin to work in interrupt mode. Correct?
> 
> You don't have to, since the pio driver will already take care of
> muxing it to the right function, but that will prevent any driver to
> call pinctrl_request on the same pin.
> 
It is still necessary?
I see that you have accepted Hans de Goede's patches: http://www.spinics.net/lists/arm-kernel/msg411142.html
>
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On Sat, Apr 11, 2015 at 07:36:14PM +0300, Aleksei Mamlin wrote:
> On Thu, 2 Apr 2015 20:50:08 +0200
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > > > +		compatible = "goodix,gt911";
> > > > > +		reg = <0x5d>;
> > > > > +		interrupt-parent = <&pio>;
> > > > > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > > > 
> > > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > > > bindings.
> > > > 
> > >
> > > Hmm. Which value I must use in this case? IRQ type is set by the
> > > touchscreen controller driver, so I think that value must be 0.
> > 
> > Whatever the hardware is using. Presumably the same value than the
> > driver sets.
> > 
> > > >
> > > > You're also not adding a pinctrl group for that pin?
> > >
> > > No, because it works fine with this DT nodes. It seems that I should
> > > first configure pin to work in interrupt mode. Correct?
> > 
> > You don't have to, since the pio driver will already take care of
> > muxing it to the right function, but that will prevent any driver to
> > call pinctrl_request on the same pin.
>
> It is still necessary?
> I see that you have accepted Hans de Goede's patches: http://www.spinics.net/lists/arm-kernel/msg411142.html

No, it's fine.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]