From: Vinod Koul <vinod.koul@intel.com>
To: yoshihiro shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"horms@verge.net.au" <horms@verge.net.au>,
kuninori morimoto <kuninori.morimoto.gx@renesas.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver
Date: Wed, 1 Apr 2015 09:13:08 +0530 [thread overview]
Message-ID: <20150401034308.GU7192@intel.com> (raw)
In-Reply-To: <HKNPR06MB32208DCB73732603FF61234D80D0@HKNPR06MB322.apcprd06.prod.outlook.com>
On Mon, Mar 23, 2015 at 02:32:07AM +0000, yoshihiro shimoda wrote:
> > > > > +static void usb_dmac_chan_remove(struct usb_dmac_chan *uchan)
> > > > > +{
> > > > > + tasklet_kill(&uchan->task);
> > > > that part is good, but how about disabling irq? you can still get insterrupt
> > >
> > > Thank you for the point! I will add calling usb_dmac_chan_halt() to disable the interrupt.
> > On top of that you should free/disable the irq as well
>
> Does this mean I should call free_irq() or something in this remove function?
Yes, that way irq can be be invoked
> Since this driver uses devm_request_irq(), I don't think the driver call such a function.
> (After this driver was removed, free_irq() was called by devm_irq_release())
Yes FW will call, but the issue is that isr can get triggered after you ahve
freed up stuff. So to prevent thsi it is recomendded that driver invoked
free_irq() explictly or disable the irq line
--
~Vinod
next prev parent reply other threads:[~2015-04-01 3:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 5:39 [PATCH v2 0/2] dmaengine: usb-dmac: Add Renesas USB DMA Controller Yoshihiro Shimoda
2015-03-11 5:39 ` [PATCH v2 1/2] dmaengine: renesas,usb-dmac: Add device tree bindings documentation Yoshihiro Shimoda
2015-03-11 5:39 ` [PATCH v2 2/2] dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver Yoshihiro Shimoda
2015-03-18 8:22 ` Vinod Koul
2015-03-19 8:12 ` yoshihiro shimoda
[not found] ` <SIXPR06MB33355F6F0532539A23ED8A9D8010-ptTgG45MbEnBsD+8QL/kzr9PrO6axcR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-03-19 9:59 ` Vinod Koul
2015-03-23 2:32 ` yoshihiro shimoda
2015-04-01 3:43 ` Vinod Koul [this message]
2015-04-01 4:09 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401034308.GU7192@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).