From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH RFC v2 04/12] drm/components: add generic vga encoder driver Date: Wed, 1 Apr 2015 11:27:51 +0100 Message-ID: <20150401102751.GZ24899@n2100.arm.linux.org.uk> References: <1427882986-19110-1-git-send-email-heiko@sntech.de> <1427882986-19110-5-git-send-email-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1427882986-19110-5-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Apr 01, 2015 at 12:09:38PM +0200, Heiko Stuebner wrote: > This adds a driver for generic vga encoders like the Analog Devices adv7123 > and similar ics. These chips do not have any special configuration options > except a powersafe gpio. > > An exception is added for the rcar-du driver which also implements support > for the adv7123 internally but is not yet converted to the component framework. Why is this implemented as a master? It's not the top level card device, it shouldn't be a master. It should be a component. I wonder if this is why you need your previous patches. Componentised DRM works fine without needing to build lists of connectors and encoders. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.