From: Tejun Heo <tj@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Suman Tripathi <stripathi@apm.com>,
devicetree@vger.kernel.org, mlangsdo@redhat.com, arnd@arndb.de,
linux-scsi@vger.kernel.org, jcm@redhat.com, patches@apm.com,
linux-ide@vger.kernel.org, olof@lixom.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ata: ahci_xgene: Add AHCI Support for second generation of APM X-Gene SoC
Date: Wed, 1 Apr 2015 12:47:48 -0400 [thread overview]
Message-ID: <20150401164748.GU9974@htj.duckdns.org> (raw)
In-Reply-To: <20150401163956.GE24899@n2100.arm.linux.org.uk>
On Wed, Apr 01, 2015 at 05:39:56PM +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 01, 2015 at 12:31:16PM -0400, Tejun Heo wrote:
> > On Wed, Apr 01, 2015 at 12:13:36PM -0400, Tejun Heo wrote:
> > > > Signed-off-by : Suman Tripathi <stripathi@apm.com>
> > >
> > > Applied to libata/for-4.1 w/ minor edit.
> >
> > Reverted due to build failure from missing asm/cputype.h.
>
> I'm guessing this is some kind of ARM driver, which is why
> linux-arm-kernel has been Cc'd - though I haven't seen the original
> patch.
It's ahci_xgene which seems to be specific to ARM.
> ARM has asm/cputype.h, and has had for a long time, so "missing
> asm/cputype.h" doesn't make sense as a reason to revert it. Maybe
As it's a new build failure I assumed that was a new file. Apparently
not.
> it's trying to be built on x86 when it should be restricted to
> only ARM?
The build failure is from kbuild and it's on PPC64 w/ COMPILE_TEST.
Urgh.. Suman, can you please update the patch to turn off COMPILE_TEST
on the driver?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-01 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 14:48 [PATCH v1] ata: ahci_xgene: Enable native NCQ and FBS for second generation of X-Gene SoC Suman Tripathi
2015-04-01 14:48 ` [PATCH v1] ata: ahci_xgene: Add AHCI Support for second generation of APM " Suman Tripathi
2015-04-01 16:13 ` Tejun Heo
2015-04-01 16:31 ` Tejun Heo
2015-04-01 16:37 ` Suman Tripathi
[not found] ` <20150401163116.GT9974-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-01 16:39 ` Russell King - ARM Linux
2015-04-01 16:47 ` Tejun Heo [this message]
[not found] ` <20150401163956.GE24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-01 17:00 ` Catalin Marinas
[not found] ` <20150401170032.GC28616-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-04-01 17:07 ` Mark Rutland
2015-04-01 17:30 ` Russell King - ARM Linux
2015-04-01 18:18 ` Catalin Marinas
2015-04-01 18:28 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401164748.GU9974@htj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mlangsdo@redhat.com \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).