From: Catalin Marinas <catalin.marinas@arm.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: devicetree@vger.kernel.org, mlangsdo@redhat.com,
Suman Tripathi <stripathi@apm.com>,
arnd@arndb.de, linux-scsi@vger.kernel.org, jcm@redhat.com,
olof@lixom.net, patches@apm.com, linux-ide@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ata: ahci_xgene: Add AHCI Support for second generation of APM X-Gene SoC
Date: Wed, 1 Apr 2015 19:18:19 +0100 [thread overview]
Message-ID: <20150401181819.GD28616@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20150401173029.GF24899@n2100.arm.linux.org.uk>
On Wed, Apr 01, 2015 at 06:30:30PM +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 01, 2015 at 06:00:33PM +0100, Catalin Marinas wrote:
> > The driver in general should not be ARM specific, though it runs on an
> > ARMv8 platform. But looking at the patch it has some errata workarounds
> > triggered based on the CPU id (MIDR). That looks dodgy as it doesn't
> > even check the full ID, only the variant part.
>
> Okay, it's not ARM but an ARM64 driver, so that's your territory, not
> mine. :)
Well, feel free to enter this territory ;).
Anyway, what I meant is that such driver should not rely on CPU
identification at all, especially since it does not require some
specific CPU features but it tries to guess which SoC revision it is and
which device (not CPU) bugs have been fixed. Better if they follow Mark
R's idea to pass such information in DT for the device.
So maybe the revert is not too bad an idea.
--
Catalin
next prev parent reply other threads:[~2015-04-01 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 14:48 [PATCH v1] ata: ahci_xgene: Enable native NCQ and FBS for second generation of X-Gene SoC Suman Tripathi
2015-04-01 14:48 ` [PATCH v1] ata: ahci_xgene: Add AHCI Support for second generation of APM " Suman Tripathi
2015-04-01 16:13 ` Tejun Heo
2015-04-01 16:31 ` Tejun Heo
2015-04-01 16:37 ` Suman Tripathi
[not found] ` <20150401163116.GT9974-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-04-01 16:39 ` Russell King - ARM Linux
2015-04-01 16:47 ` Tejun Heo
[not found] ` <20150401163956.GE24899-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-01 17:00 ` Catalin Marinas
[not found] ` <20150401170032.GC28616-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-04-01 17:07 ` Mark Rutland
2015-04-01 17:30 ` Russell King - ARM Linux
2015-04-01 18:18 ` Catalin Marinas [this message]
2015-04-01 18:28 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401181819.GD28616@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mlangsdo@redhat.com \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).