From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [STLinux Kernel] [PATCH 0/4] clk: Provide support for always-on clocks Date: Thu, 2 Apr 2015 11:58:03 +0100 Message-ID: <20150402105803.GD9447@x1> References: <1425071674-16995-1-git-send-email-lee.jones@linaro.org> <20150402081210.GB3567@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Gabriel Fernandez Cc: Peter Griffin , "devicetree@vger.kernel.org" , Mike Turquette , "kernel@stlinux.com" , sboyd@codeaurora.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > With these series as they are, we need 'clk_ignore_unused' on > sthi407-b2120.dts and stih418-b2199.dts. >=20 > We have to modificate stih407-clock.dtsi and stih418-clock.dtsi in sa= me way. Just to clarify this point for all interested parties; this patch-set is not the completed article. It's purpose is to add the core functionality and the documentation _only_. The STiH410 support is only provided in this set as an example of how the bindings are to be used. Other platforms are to be enabled subsequently as part of a different submission. > On 2 April 2015 at 10:12, Peter Griffin wr= ote: > > Hi Lee, > > > > On Fri, 27 Feb 2015, Lee Jones wrote: > > > >> Some hardware contains bunches of clocks which must never be > >> turned off. If drivers a) fail to obtain a reference to any > >> of these or b) give up a previously obtained reference > >> during suspend, the common clk framework will attempt to > >> disable them and a platform can fail irrecoverably as a > >> result. Usually the only way to recover from these failures > >> is to reboot. > >> > >> To avoid either of these two scenarios from catastrophically > >> disabling an otherwise perfectly healthy running system, > >> clocks can be identified as always-on using this property > >> from inside a clocksource's node. The CLK_IGNORE_UNUSED > >> flag will be applied to each clock instance named in this > >> property, thus preventing them from being shut down by the > >> framework. > > > > Great stuff. > > > > One minor comment is that assuming this works on stih407 and stih41= 0 > > to the extent that the platform can now boot without clk_ignore_unu= sed > > kenel parameter then you should have an additional patch to remove > > clk_ignore_unused from the default bootargs in stih407-b2120.dts an= d > > stih410-b2120.dts files. > > > > Maxime - Is it possible for you to test this series on stih418-b219= 9 as > > a well? As it could most likely also be removed from stih418-b2199.= dts file > > to, but neither Lee or myself have the hardware to test. > > > > Apart from that, for the series: - > > Acked-by: Peter Griffin > > > > regards, > > > > Peter. > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog