From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties Date: Thu, 2 Apr 2015 16:41:34 +0200 Message-ID: <20150402144134.GA18125@amd> References: <1427809965-25540-1-git-send-email-j.anaszewski@samsung.com> <1427809965-25540-2-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1427809965-25540-2-git-send-email-j.anaszewski@samsung.com> Sender: linux-media-owner@vger.kernel.org To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, kyungmin.park@samsung.com, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Sakari Ailus , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue 2015-03-31 15:52:37, Jacek Anaszewski wrote: > Description of flash LEDs related properties was not precise regarding > the state of corresponding settings in case a property is missing. > Add relevant statements. > Removed is also the requirement making the flash-max-microamp > property obligatory for flash LEDs. It was inconsistent as the property > is defined as optional. Devices which require the property will have > to assert this in their DT bindings. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie Acked-by: Pavel Machek > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 747c538..21a25e4 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -29,13 +29,15 @@ Optional properties for child nodes: > "ide-disk" - LED indicates disk activity > "timer" - LED flashes at a fixed, configurable rate > > -- max-microamp : maximum intensity in microamperes of the LED > - (torch LED for flash devices) > -- flash-max-microamp : maximum intensity in microamperes of the > - flash LED; it is mandatory if the LED should > - support the flash mode > -- flash-timeout-us : timeout in microseconds after which the flash > - LED is turned off > +- max-microamp : Maximum intensity in microamperes of the LED > + (torch LED for flash devices). If omitted this will default > + to the maximum current allowed by the device. > +- flash-max-microamp : Maximum intensity in microamperes of the flash LED. > + If omitted this will default to the maximum > + current allowed by the device. > +- flash-timeout-us : Timeout in microseconds after which the flash > + LED is turned off. If omitted this will default to the > + maximum timeout allowed by the device. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html