From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200
Date: Thu, 2 Apr 2015 20:50:08 +0200 [thread overview]
Message-ID: <20150402185008.GC14618@lukather> (raw)
In-Reply-To: <20150331223120.10199bf9e3fb41b16f879eca-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > + compatible = "goodix,gt911";
> > > + reg = <0x5d>;
> > > + interrupt-parent = <&pio>;
> > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> >
> > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > bindings.
> >
>
> Hmm. Which value I must use in this case? IRQ type is set by the
> touchscreen controller driver, so I think that value must be 0.
Whatever the hardware is using. Presumably the same value than the
driver sets.
> >
> > You're also not adding a pinctrl group for that pin?
>
> No, because it works fine with this DT nodes. It seems that I should
> first configure pin to work in interrupt mode. Correct?
You don't have to, since the pio driver will already take care of
muxing it to the right function, but that will prevent any driver to
call pinctrl_request on the same pin.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-02 18:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 8:18 [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 Aleksei Mamlin
[not found] ` <1427789897-4085-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-31 14:43 ` Maxime Ripard
2015-03-31 19:14 ` Aleksei Mamlin
[not found] ` <20150331221420.3b65d2540c7dbe1d12611e12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-02 9:22 ` Maxime Ripard
2015-04-11 16:18 ` Aleksei Mamlin
[not found] ` <20150411191816.cdc5ec802b01028eb2913906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-13 16:09 ` Maxime Ripard
2015-04-13 19:01 ` Aleksei Mamlin
[not found] ` <20150413220100.8666a3d121fce581ba836fe6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-14 16:32 ` Maxime Ripard
2015-03-31 19:31 ` Aleksei Mamlin
[not found] ` <20150331223120.10199bf9e3fb41b16f879eca-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-02 18:50 ` Maxime Ripard [this message]
2015-04-11 16:36 ` Aleksei Mamlin
[not found] ` <20150411193614.83013f345aaa1123ef55ecbf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-13 15:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402185008.GC14618@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).