From: Sebastian Reichel <sre@kernel.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Pavel Machek <pavel@ucw.cz>, Andrew Morton <akpm@osdl.org>,
pali.rohar@gmail.com, kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
sakari.ailus@iki.fi, m.chehab@samsung.com,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653
Date: Fri, 3 Apr 2015 16:22:56 +0200 [thread overview]
Message-ID: <20150403142256.GA13595@earth> (raw)
In-Reply-To: <CABxcv=mVdw7QkUWSqa1=VRJD+mHCU3dP09SBxVERs1NWUBeWiA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
Hi,
On Fri, Apr 03, 2015 at 10:49:12AM +0200, Javier Martinez Canillas wrote:
> >> The convention nowadays is to not use unnamed DT properties for GPIOs
> >> but instead use a prefix that explains what those GPIOs are used for.
> >> So something like "power-gpios" or "power-gpio" (if there is only one
> >> GPIO) will be more suitable. Please take a look to
> >> Documentation/gpio/board.txt for more details.
> >
> > Ok. Actually, reading docs below, "power-gpio" will not work, and it
> > needs to be "power-gpios", right?
> >
>
> No, the documentation is not updated. People used <function>-gpio so
> at the end it was added as another supported suffix, see commit:
> dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names").
>
> But I guess it doesn't matter if -gpio or -gpios is used.
I suggest to use enable-gpio(s), since the pin is called "enable" in
the datasheet.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-03 14:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:38 [PATCHv3] media: i2c/adp1653: devicetree support for adp1653 Pavel Machek
2015-04-02 16:14 ` Sakari Ailus
[not found] ` <20150402161453.GH20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-02 20:30 ` Pavel Machek
2015-04-02 23:48 ` Sakari Ailus
2015-04-03 8:23 ` Pavel Machek
2015-04-03 11:23 ` Sakari Ailus
2015-04-03 20:29 ` Pavel Machek
2015-04-03 21:35 ` Sakari Ailus
2015-04-02 20:34 ` [PATCHv4] " Pavel Machek
2015-04-02 22:18 ` Javier Martinez Canillas
[not found] ` <CABxcv=nfg_D9HvXUd4PBFJ5a1XST=PCDEZCjkTtbu_u7cc1+ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-03 8:21 ` Pavel Machek
2015-04-03 8:49 ` Javier Martinez Canillas
2015-04-03 14:22 ` Sebastian Reichel [this message]
2015-04-03 8:33 ` [PATCHv5] " Pavel Machek
2015-04-03 11:32 ` Sakari Ailus
2015-04-03 20:26 ` [PATCHv6] media: i2c/adp1653: Documentation for " Pavel Machek
2015-04-03 21:36 ` Sakari Ailus
2015-04-04 7:43 ` Pavel Machek
2015-04-04 10:24 ` Sakari Ailus
[not found] ` <20150404102435.GR20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-04 17:11 ` Pavel Machek
2015-04-04 20:03 ` Sakari Ailus
2015-04-09 7:42 ` [PATCHv7] media: i2c/adp1653: Devicetree " Pavel Machek
2015-04-09 9:10 ` Sebastian Reichel
2015-04-09 11:29 ` Pavel Machek
2015-04-09 12:19 ` Sebastian Reichel
2015-04-09 12:31 ` [PATCHv7] media: i2c/adp1653: fix includes Pavel Machek
2015-04-09 12:43 ` Javier Martinez Canillas
2015-04-09 12:59 ` Pali Rohár
2015-04-13 8:32 ` Javier Martinez Canillas
2015-04-09 21:47 ` [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 Sakari Ailus
[not found] ` <20150409214739.GD20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-13 13:00 ` Pavel Machek
2015-04-03 21:39 ` [PATCHv6] media: i2c/adp1653: Documentation for devicetree " Sakari Ailus
[not found] ` <20150403113216.GK20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-03 21:04 ` [PATCHv5] media: i2c/adp1653: " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403142256.GA13595@earth \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@osdl.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=javier@dowhile0.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).