From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org,
sre-GFxCN5SEZAc@public.gmane.org,
kernel list
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
aaro.koskinen-X3B1VOXEql0@public.gmane.org,
ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv5] media: i2c/adp1653: devicetree support for adp1653
Date: Fri, 3 Apr 2015 23:04:39 +0200 [thread overview]
Message-ID: <20150403210439.GC13009@amd> (raw)
In-Reply-To: <20150403113216.GK20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
Hi!
> > + pd->max_flash_intensity = val/1000;
> > +
> > + if (of_property_read_u32(child, "max-microamp", &val))
> > + return -EINVAL;
> > + pd->max_torch_intensity = val/1000;
>
> I think you need to do of_node_put(child) here and after you're done with
> indicator below.
...and in most of the error paths. Ok. Will submit the updated patch
when the documentation one is accepted.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-04-03 21:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:38 [PATCHv3] media: i2c/adp1653: devicetree support for adp1653 Pavel Machek
2015-04-02 16:14 ` Sakari Ailus
[not found] ` <20150402161453.GH20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-02 20:30 ` Pavel Machek
2015-04-02 23:48 ` Sakari Ailus
2015-04-03 8:23 ` Pavel Machek
2015-04-03 11:23 ` Sakari Ailus
2015-04-03 20:29 ` Pavel Machek
2015-04-03 21:35 ` Sakari Ailus
2015-04-02 20:34 ` [PATCHv4] " Pavel Machek
2015-04-02 22:18 ` Javier Martinez Canillas
[not found] ` <CABxcv=nfg_D9HvXUd4PBFJ5a1XST=PCDEZCjkTtbu_u7cc1+ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-03 8:21 ` Pavel Machek
2015-04-03 8:49 ` Javier Martinez Canillas
2015-04-03 14:22 ` Sebastian Reichel
2015-04-03 8:33 ` [PATCHv5] " Pavel Machek
2015-04-03 11:32 ` Sakari Ailus
2015-04-03 20:26 ` [PATCHv6] media: i2c/adp1653: Documentation for " Pavel Machek
2015-04-03 21:36 ` Sakari Ailus
2015-04-04 7:43 ` Pavel Machek
2015-04-04 10:24 ` Sakari Ailus
[not found] ` <20150404102435.GR20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-04 17:11 ` Pavel Machek
2015-04-04 20:03 ` Sakari Ailus
2015-04-09 7:42 ` [PATCHv7] media: i2c/adp1653: Devicetree " Pavel Machek
2015-04-09 9:10 ` Sebastian Reichel
2015-04-09 11:29 ` Pavel Machek
2015-04-09 12:19 ` Sebastian Reichel
2015-04-09 12:31 ` [PATCHv7] media: i2c/adp1653: fix includes Pavel Machek
2015-04-09 12:43 ` Javier Martinez Canillas
2015-04-09 12:59 ` Pali Rohár
2015-04-13 8:32 ` Javier Martinez Canillas
2015-04-09 21:47 ` [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 Sakari Ailus
[not found] ` <20150409214739.GD20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-13 13:00 ` Pavel Machek
2015-04-03 21:39 ` [PATCHv6] media: i2c/adp1653: Documentation for devicetree " Sakari Ailus
[not found] ` <20150403113216.GK20756-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-04-03 21:04 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403210439.GC13009@amd \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
--cc=sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
--cc=sre-GFxCN5SEZAc@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).