From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/5] MFD/OF: document MFD devices and handle simple-mfd Date: Tue, 7 Apr 2015 08:16:18 +0100 Message-ID: <20150407071618.GE3461@x1> References: <1425375148-4369-1-git-send-email-linus.walleij@linaro.org> <1425375148-4369-2-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Linus Walleij , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Arnd Bergmann , Bryan Wu , Catalin Marinas , Will Deacon , Richard Purdie , Devicetree , Rob Herring , Benjamin Herrenschmidt , Grant Likely , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org On Fri, 03 Apr 2015, Olof Johansson wrote: > Hi, >=20 > I understand this is bikeshedding to some extent, but I'd also like t= o > avoid needless variation in binding formats: >=20 > On Tue, Mar 3, 2015 at 1:32 AM, Linus Walleij wrote: >=20 > > + > > +foo@1000 { > > + compatible =3D "syscon", "simple-mfd"; > > + reg =3D <0x010000 0x1000>; > > + > > + led@08.0 { >=20 > This doesn't seem to be a typo, you're using a period in the unit > address. I've never seen that done before, usually commas are used > instead. >=20 > Was there a reason for going with period? LEDs have always done it [1]. I guess Bryan would be the best person to answer the 'why'. git grep "led.*@[0-9]*[.,][0-9]*" -- Documentation/devicetree/ arch/arm= /boot/dts/ --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html