devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: vinod.koul@intel.com, linux@arm.linux.org.uk,
	grant.likely@linaro.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, nm@ti.com, arnd@arndb.de,
	maxime.ripard@free-electrons.com
Subject: Re: [PATCH v5 8/8] ARM: DTS: dra7x: Integrate sDMA crossbar
Date: Thu, 9 Apr 2015 08:18:46 -0700	[thread overview]
Message-ID: <20150409151846.GR18048@atomide.com> (raw)
In-Reply-To: <1428572154-3548-9-git-send-email-peter.ujfalusi@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [150409 02:37]:
> The sDMA requests are routed through the DMA crossbar and without the
> crossbar only peripherals using DMA request 0-127 can be used.

I assume this can be merged separately from the driver
changes?

Otherwise we'll have the same kind of "flag day" mess with
the IRQ crossbar..

Regards,

Tony
 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 57 ++++++++++++++++++++++++++-------------------
>  1 file changed, 33 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 5332b57b4950..a2f4aa01984f 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -303,6 +303,15 @@
>  			dma-requests = <127>;
>  		};
>  
> +		sdma_xbar: dma-router@4a002b78 {
> +			compatible = "ti,dra7-dma-crossbar";
> +			reg = <0x4a002b78 0xfc>;
> +			#dma-cells = <1>;
> +			dma-requests = <205>;
> +			ti,dma-safe-map = <0>;
> +			dma-masters = <&sdma>;
> +		};
> +
>  		gpio1: gpio@4ae10000 {
>  			compatible = "ti,omap4-gpio";
>  			reg = <0x4ae10000 0x200>;
> @@ -398,7 +407,7 @@
>  			ti,hwmods = "uart1";
>  			clock-frequency = <48000000>;
>  			status = "disabled";
> -			dmas = <&sdma 49>, <&sdma 50>;
> +			dmas = <&sdma_xbar 49>, <&sdma_xbar 50>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -409,7 +418,7 @@
>  			ti,hwmods = "uart2";
>  			clock-frequency = <48000000>;
>  			status = "disabled";
> -			dmas = <&sdma 51>, <&sdma 52>;
> +			dmas = <&sdma_xbar 51>, <&sdma_xbar 52>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -420,7 +429,7 @@
>  			ti,hwmods = "uart3";
>  			clock-frequency = <48000000>;
>  			status = "disabled";
> -			dmas = <&sdma 53>, <&sdma 54>;
> +			dmas = <&sdma_xbar 53>, <&sdma_xbar 54>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -431,7 +440,7 @@
>  			ti,hwmods = "uart4";
>  			clock-frequency = <48000000>;
>                          status = "disabled";
> -			dmas = <&sdma 55>, <&sdma 56>;
> +			dmas = <&sdma_xbar 55>, <&sdma_xbar 56>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -442,7 +451,7 @@
>  			ti,hwmods = "uart5";
>  			clock-frequency = <48000000>;
>  			status = "disabled";
> -			dmas = <&sdma 63>, <&sdma 64>;
> +			dmas = <&sdma_xbar 63>, <&sdma_xbar 64>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -453,7 +462,7 @@
>  			ti,hwmods = "uart6";
>  			clock-frequency = <48000000>;
>  			status = "disabled";
> -			dmas = <&sdma 79>, <&sdma 80>;
> +			dmas = <&sdma_xbar 79>, <&sdma_xbar 80>;
>  			dma-names = "tx", "rx";
>  		};
>  
> @@ -862,7 +871,7 @@
>  			ti,hwmods = "mmc1";
>  			ti,dual-volt;
>  			ti,needs-special-reset;
> -			dmas = <&sdma 61>, <&sdma 62>;
> +			dmas = <&sdma_xbar 61>, <&sdma_xbar 62>;
>  			dma-names = "tx", "rx";
>  			status = "disabled";
>  			pbias-supply = <&pbias_mmc_reg>;
> @@ -874,7 +883,7 @@
>  			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>  			ti,hwmods = "mmc2";
>  			ti,needs-special-reset;
> -			dmas = <&sdma 47>, <&sdma 48>;
> +			dmas = <&sdma_xbar 47>, <&sdma_xbar 48>;
>  			dma-names = "tx", "rx";
>  			status = "disabled";
>  		};
> @@ -885,7 +894,7 @@
>  			interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
>  			ti,hwmods = "mmc3";
>  			ti,needs-special-reset;
> -			dmas = <&sdma 77>, <&sdma 78>;
> +			dmas = <&sdma_xbar 77>, <&sdma_xbar 78>;
>  			dma-names = "tx", "rx";
>  			status = "disabled";
>  		};
> @@ -896,7 +905,7 @@
>  			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
>  			ti,hwmods = "mmc4";
>  			ti,needs-special-reset;
> -			dmas = <&sdma 57>, <&sdma 58>;
> +			dmas = <&sdma_xbar 57>, <&sdma_xbar 58>;
>  			dma-names = "tx", "rx";
>  			status = "disabled";
>  		};
> @@ -1041,14 +1050,14 @@
>  			#size-cells = <0>;
>  			ti,hwmods = "mcspi1";
>  			ti,spi-num-cs = <4>;
> -			dmas = <&sdma 35>,
> -			       <&sdma 36>,
> -			       <&sdma 37>,
> -			       <&sdma 38>,
> -			       <&sdma 39>,
> -			       <&sdma 40>,
> -			       <&sdma 41>,
> -			       <&sdma 42>;
> +			dmas = <&sdma_xbar 35>,
> +			       <&sdma_xbar 36>,
> +			       <&sdma_xbar 37>,
> +			       <&sdma_xbar 38>,
> +			       <&sdma_xbar 39>,
> +			       <&sdma_xbar 40>,
> +			       <&sdma_xbar 41>,
> +			       <&sdma_xbar 42>;
>  			dma-names = "tx0", "rx0", "tx1", "rx1",
>  				    "tx2", "rx2", "tx3", "rx3";
>  			status = "disabled";
> @@ -1062,10 +1071,10 @@
>  			#size-cells = <0>;
>  			ti,hwmods = "mcspi2";
>  			ti,spi-num-cs = <2>;
> -			dmas = <&sdma 43>,
> -			       <&sdma 44>,
> -			       <&sdma 45>,
> -			       <&sdma 46>;
> +			dmas = <&sdma_xbar 43>,
> +			       <&sdma_xbar 44>,
> +			       <&sdma_xbar 45>,
> +			       <&sdma_xbar 46>;
>  			dma-names = "tx0", "rx0", "tx1", "rx1";
>  			status = "disabled";
>  		};
> @@ -1078,7 +1087,7 @@
>  			#size-cells = <0>;
>  			ti,hwmods = "mcspi3";
>  			ti,spi-num-cs = <2>;
> -			dmas = <&sdma 15>, <&sdma 16>;
> +			dmas = <&sdma_xbar 15>, <&sdma_xbar 16>;
>  			dma-names = "tx0", "rx0";
>  			status = "disabled";
>  		};
> @@ -1091,7 +1100,7 @@
>  			#size-cells = <0>;
>  			ti,hwmods = "mcspi4";
>  			ti,spi-num-cs = <1>;
> -			dmas = <&sdma 70>, <&sdma 71>;
> +			dmas = <&sdma_xbar 70>, <&sdma_xbar 71>;
>  			dma-names = "tx0", "rx0";
>  			status = "disabled";
>  		};
> -- 
> 2.3.5
> 

  reply	other threads:[~2015-04-09 15:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  9:35 [PATCH v5 0/8] dmaengine/dra7x: DMA router (crossbar support) Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 1/8] dmaengine: of_dma: Support for DMA routers Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 2/8] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x Peter Ujfalusi
     [not found]   ` <1428572154-3548-4-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-05-04  5:38     ` Vinod Koul
2015-05-07  9:48       ` Peter Ujfalusi
     [not found]         ` <554B34F2.5050306-l0cyMroinI0@public.gmane.org>
2015-05-08  3:41           ` Vinod Koul
2015-05-08  7:05             ` Peter Ujfalusi
     [not found]               ` <554C6034.4020004-l0cyMroinI0@public.gmane.org>
2015-05-08  9:03                 ` Vinod Koul
2015-05-08 15:09                   ` Tony Lindgren
2015-05-08 17:44                     ` Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 4/8] dmaengine: omap-dma: Use defines for dma channels and request count Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 5/8] dmaengine: omap-dma: Take DMA request number from DT if it is available Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 6/8] dmaengine: omap-dma: Remove mapping between virtual channels and requests Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 7/8] dmaengine: omap-dma: Reduce the number of virtual channels Peter Ujfalusi
2015-04-09  9:35 ` [PATCH v5 8/8] ARM: DTS: dra7x: Integrate sDMA crossbar Peter Ujfalusi
2015-04-09 15:18   ` Tony Lindgren [this message]
2015-04-09 18:50     ` Peter Ujfalusi
2015-04-09 19:01       ` Tony Lindgren
2015-04-09 19:05         ` Peter Ujfalusi
     [not found]           ` <5526CD6A.8010300-l0cyMroinI0@public.gmane.org>
2015-04-09 19:12             ` Tony Lindgren
2015-07-14 10:28               ` Tony Lindgren
2015-05-04  5:40   ` Vinod Koul
2015-04-22  7:38 ` [PATCH v5 0/8] dmaengine/dra7x: DMA router (crossbar support) Peter Ujfalusi
2015-05-09 11:44 ` Vinod Koul
2015-05-13 14:57   ` Peter Ujfalusi
2015-05-14 15:21     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409151846.GR18048@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=maxime.ripard@free-electrons.com \
    --cc=nm@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).