* Re: [PATCH] ARM: dts: imx23-olinuxino: Fix dr_mode of usb0
[not found] ` <1429043846-28731-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
@ 2015-04-14 20:43 ` Fabio Estevam
2015-04-15 2:59 ` Marek Vasut
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-04-14 20:43 UTC (permalink / raw)
To: Stefan Wahren
Cc: Shawn Guo, Fabio Estevam, Marek Vašut, Sascha Hauer,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Harald Geyer, Peter Chen
On Tue, Apr 14, 2015 at 5:37 PM, Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
>
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
>
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
>
> Reported-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Reviewed-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx23-olinuxino: Fix dr_mode of usb0
[not found] ` <1429043846-28731-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2015-04-14 20:43 ` Fabio Estevam
@ 2015-04-15 2:59 ` Marek Vasut
2015-04-15 3:32 ` Peter Chen
2015-04-27 12:26 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2015-04-15 2:59 UTC (permalink / raw)
To: Stefan Wahren
Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A,
fabio.estevam-KZfg59tc24xl57MIdRCFDg,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
harald-95f8Dae0BrPYtjvyW6yDsg, peter.chen-KZfg59tc24xl57MIdRCFDg
On Tuesday, April 14, 2015 at 10:37:26 PM, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
>
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
>
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
>
> Reported-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Reviewed-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx23-olinuxino: Fix dr_mode of usb0
[not found] ` <1429043846-28731-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2015-04-14 20:43 ` Fabio Estevam
2015-04-15 2:59 ` Marek Vasut
@ 2015-04-15 3:32 ` Peter Chen
2015-04-15 19:11 ` Stefan Wahren
2015-04-27 12:26 ` Shawn Guo
3 siblings, 1 reply; 6+ messages in thread
From: Peter Chen @ 2015-04-15 3:32 UTC (permalink / raw)
To: Stefan Wahren
Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A,
fabio.estevam-KZfg59tc24xl57MIdRCFDg, marex-ynQEQJNshbs,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
harald-95f8Dae0BrPYtjvyW6yDsg
On Tue, Apr 14, 2015 at 08:37:26PM +0000, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
>
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
>
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
>
> Reported-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> ---
> arch/arm/boot/dts/imx23-olinuxino.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
> index 7e6eef2..3b2d74d 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -93,6 +93,7 @@
>
> ahb@80080000 {
> usb0: usb@80080000 {
> + dr_mode = "host";
> vbus-supply = <®_usb0_vbus>;
> status = "okay";
> };
> --
> 1.7.9.5
>
If this board has only host function, I am ok for it.
Acked-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx23-olinuxino: Fix dr_mode of usb0
2015-04-15 3:32 ` Peter Chen
@ 2015-04-15 19:11 ` Stefan Wahren
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2015-04-15 19:11 UTC (permalink / raw)
To: Peter Chen
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, shawn.guo-QSEj5FYQhm4dnm+yROfE0A,
fabio.estevam-KZfg59tc24xl57MIdRCFDg,
harald-95f8Dae0BrPYtjvyW6yDsg,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
marex-ynQEQJNshbs, devicetree-u79uwXL29TY76Z2rM5mHXA
Hi Peter,
> Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> hat am 15. April 2015 um 05:32
> geschrieben:
>
>
> [...]
>
> If this board has only host function, I am ok for it.
Yes, all 4 boards (Maxi [1], Micro [2], Mini [3], Nano [4]) have only host
function.
>
> Acked-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Thanks
Stefan
[1] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Maxi/iMX233-OLINUXINO-MAXI_Rev_D.pdf
[2] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Micro/iMX233-OLinuXino-Micro_Rev_D.pdf
[3] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Mini/iMX233-OLINUXINO-MINI_Rev_C.sch.pdf
[4] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-NANO/iMX233-OLinuXino-NANO_Rev_B.pdf
>
> --
>
> Best Regards,
> Peter Chen
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx23-olinuxino: Fix dr_mode of usb0
[not found] ` <1429043846-28731-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
` (2 preceding siblings ...)
2015-04-15 3:32 ` Peter Chen
@ 2015-04-27 12:26 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2015-04-27 12:26 UTC (permalink / raw)
To: Stefan Wahren
Cc: fabio.estevam-KZfg59tc24xl57MIdRCFDg, marex-ynQEQJNshbs,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
harald-95f8Dae0BrPYtjvyW6yDsg, peter.chen-KZfg59tc24xl57MIdRCFDg
On Tue, Apr 14, 2015 at 08:37:26PM +0000, Stefan Wahren wrote:
> The dr_mode of usb0 on imx233-olinuxino is left to default "otg".
> Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the
> same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
>
> echo 0 > /sys/class/leds/green/brightness
> [ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
> [ 1068.890000] usb usb1: USB disconnect, device number 1
> [ 1068.920000] usb 1-1: USB disconnect, device number 2
> [ 1068.920000] usb 1-1.1: USB disconnect, device number 3
> [ 1069.070000] usb 1-1.2: USB disconnect, device number 4
> [ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
> [ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
>
> This patch fixes the issue by setting dr_mode to "host" in the dts file.
>
> Reported-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread