[PATCH] of: base: improve of_get_next_child() kernel-doc

[PATCH] of: base: improve of_get_next_child() kernel-doc

[Baruch Siach]

Add two new facts to of_get_next_child() documentation:

   * of_get_next_child() returns NULL when there is not next child

   * of_get_next_child() decrements the refcount of prev

Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
---
 drivers/of/base.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index adb8764861c0..5ca5f900de9c 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -640,8 +640,9 @@ static struct device_node *__of_get_next_child(const struct device_node *node,
  *	@node:	parent node
  *	@prev:	previous child of the parent node, or NULL to get first
  *
- *	Returns a node pointer with refcount incremented, use
- *	of_node_put() on it when done.
+ *	Returns a node pointer with refcount incremented, use of_node_put() on
+ *	it when done. Returns NULL when prev is the last child. Decrements the
+ *	refcount of prev.
  */
 struct device_node *of_get_next_child(const struct device_node *node,
 	struct device_node *prev)
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: improve of_get_next_child() kernel-doc

[Rob Herring]

On Thu, Mar 19, 2015 at 7:03 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> Add two new facts to of_get_next_child() documentation:
>
>    * of_get_next_child() returns NULL when there is not next child
>
>    * of_get_next_child() decrements the refcount of prev
>
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

Applied. Thanks.

Rob

> ---
>  drivers/of/base.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index adb8764861c0..5ca5f900de9c 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -640,8 +640,9 @@ static struct device_node *__of_get_next_child(const struct device_node *node,
>   *     @node:  parent node
>   *     @prev:  previous child of the parent node, or NULL to get first
>   *
> - *     Returns a node pointer with refcount incremented, use
> - *     of_node_put() on it when done.
> + *     Returns a node pointer with refcount incremented, use of_node_put() on
> + *     it when done. Returns NULL when prev is the last child. Decrements the
> + *     refcount of prev.
>   */
>  struct device_node *of_get_next_child(const struct device_node *node,
>         struct device_node *prev)
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: improve of_get_next_child() kernel-doc

[Baruch Siach]

Hi Rob,

On Tue, Mar 24, 2015 at 11:45:16PM -0500, Rob Herring wrote:
> On Thu, Mar 19, 2015 at 7:03 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> > Add two new facts to of_get_next_child() documentation:
> >
> >    * of_get_next_child() returns NULL when there is not next child
> >
> >    * of_get_next_child() decrements the refcount of prev
> >
> > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> 
> Applied. Thanks.

Thanks. Which tree is this patch going through? I don't see it in current 
-next (next-20150327).

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: improve of_get_next_child() kernel-doc

[Baruch Siach]

Hi Rob,

On Sat, Mar 28, 2015 at 11:29:39PM +0300, Baruch Siach wrote:
> On Tue, Mar 24, 2015 at 11:45:16PM -0500, Rob Herring wrote:
> > On Thu, Mar 19, 2015 at 7:03 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> > > Add two new facts to of_get_next_child() documentation:
> > >
> > >    * of_get_next_child() returns NULL when there is not next child
> > >
> > >    * of_get_next_child() decrements the refcount of prev
> > >
> > > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> > 
> > Applied. Thanks.
> 
> Thanks. Which tree is this patch going through? I don't see it in current 
> -next (next-20150327).

Ping?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: improve of_get_next_child() kernel-doc

[Rob Herring]

On Thu, Apr 16, 2015 at 11:46 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> Hi Rob,
>
> On Sat, Mar 28, 2015 at 11:29:39PM +0300, Baruch Siach wrote:
>> On Tue, Mar 24, 2015 at 11:45:16PM -0500, Rob Herring wrote:
>> > On Thu, Mar 19, 2015 at 7:03 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
>> > > Add two new facts to of_get_next_child() documentation:
>> > >
>> > >    * of_get_next_child() returns NULL when there is not next child
>> > >
>> > >    * of_get_next_child() decrements the refcount of prev
>> > >
>> > > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
>> >
>> > Applied. Thanks.
>>
>> Thanks. Which tree is this patch going through? I don't see it in current
>> -next (next-20150327).
>
> Ping?

Somehow I dropped this. Anyway, now it is applied and sent to Linus.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html