From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653 Date: Thu, 16 Apr 2015 21:22:35 +0200 Message-ID: <20150416192235.GA8188@amd> References: <1429141034-29237-1-git-send-email-sakari.ailus@iki.fi> <20150416052442.GA31095@earth> <20150416055817.GA2749@amd> <20150416162905.GA3181@earth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150416162905.GA3181@earth> Sender: linux-leds-owner@vger.kernel.org To: Sebastian Reichel Cc: Sakari Ailus , linux-leds@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi! > > > This will reduce complexity in the driver and should be fairly easy > > > to implement, since there is no adp1653 platform code user in the > > > mainline kernel anyways. > > > > I'd hate to break out of tree users for very little gain. ... > So let's have a look at the advantages of removing the power gpio: One change per patch. My change did what it said, "add a device tree support", if you want to do second change "break existing interface", feel free doing it as a separate patch. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html