From: Mark Rutland <mark.rutland@arm.com>
To: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
Cc: "horms@verge.net.au" <horms@verge.net.au>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>
Subject: Re: [RFC/PATCH v2 3/5] devicetree: bindings: Add new cpuidle enable method for Renesas R-car SoCs
Date: Fri, 17 Apr 2015 13:46:25 +0100 [thread overview]
Message-ID: <20150417124624.GD21904@leverpostej> (raw)
In-Reply-To: <1429180540-5692-4-git-send-email-keita.kobayashi.ym@renesas.com>
On Thu, Apr 16, 2015 at 11:35:38AM +0100, Keita Kobayashi wrote:
> This patch add the ARM CPUs Device Tree binding to document a new
> enable method of Renesas cpuidle.
>
> Signed-off-by: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
> ---
> Documentation/devicetree/bindings/arm/cpus.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
> index 8b9e0a9..663ee11 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.txt
> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> @@ -196,6 +196,7 @@ nodes to be present and contain the properties described below.
> "qcom,gcc-msm8660"
> "qcom,kpss-acc-v1"
> "qcom,kpss-acc-v2"
> + "renesas,rcar-idle"
The enable-method is about how to bring the CPU up (and potentially
implies other things, like how to take it down again).
These is no code in this series to that effect, no semantics are
provided, and the name implies this is idle-specific.
So this doesn't look right, and makes no sense to me.
Mark.
next prev parent reply other threads:[~2015-04-17 12:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 10:35 [RFC/PATCH v2 0/5] Add cpuidle support for r8a7791 Keita Kobayashi
2015-04-16 10:35 ` [RFC/PATCH v2 1/5] ARM: cpuidle: Add cpuidle support for R-Car Gen2 series Keita Kobayashi
2015-04-17 12:14 ` Magnus Damm
2015-04-20 6:54 ` keita kobayashi
2015-04-16 10:35 ` [RFC/PATCH v2 2/5] ARM: shmobile: Add cpuidle_ops for R-Car cpuidle Keita Kobayashi
2015-04-16 10:35 ` [RFC/PATCH v2 3/5] devicetree: bindings: Add new cpuidle enable method for Renesas R-car SoCs Keita Kobayashi
[not found] ` <1429180540-5692-4-git-send-email-keita.kobayashi.ym-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2015-04-17 12:26 ` Magnus Damm
2015-04-17 12:46 ` Mark Rutland [this message]
2015-04-17 13:11 ` Magnus Damm
[not found] ` <CANqRtoTaGc7QCJAVj8Jhpo5HgbwyfiRQZz5j0zBkE1cBkDZAzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-17 14:37 ` Lorenzo Pieralisi
2015-04-20 7:39 ` keita kobayashi
2015-04-21 10:55 ` Lorenzo Pieralisi
2015-04-16 10:35 ` [RFC/PATCH v2 4/5] ARM: shmobile: dtsi: Add cpuidle parameters into each cpu for r8a7791 Keita Kobayashi
2015-04-16 10:35 ` [RFC/PATCH v2 5/5] ARM: shmobile: Enable Renesas R-Car cpuidle for shmobile_defconfig Keita Kobayashi
2015-04-17 8:19 ` [RFC/PATCH v2 0/5] Add cpuidle support for r8a7791 Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417124624.GD21904@leverpostej \
--to=mark.rutland@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=keita.kobayashi.ym@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).