From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Kevin Cernekee <cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers
Date: Mon, 20 Apr 2015 21:14:01 +0100 [thread overview]
Message-ID: <20150420201401.GP6023@sirena.org.uk> (raw)
In-Reply-To: <CAJzqFtY3-jYTS-NmAE4UtsD+VXZHBUJUVuVQ=X4htB1akCThMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Mon, Apr 20, 2015 at 08:12:36AM -0700, Kevin Cernekee wrote:
> On Mon, Apr 20, 2015 at 5:21 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >> The same check shows up in numerous other drivers, including the one
> >> for the audio controller on my board.
> > Sounds like either that (undisclosed) driver has a problem or you're
> > using it inappropriately.
> I don't think this driver has been posted on the list yet, but the
> checks show up in these two functions:
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#108
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/sound/soc/img/concerto-audio.c#147
> Any suggestions on what to change?
That driver has not been posted previously (and looks like it could use
some rework for mainline). If it doesn't care if it set the clock and
is just trying for information it should be handling -ENOTSUPP, that's
why the core returns that value.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-20 20:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 21:42 [PATCH 1/3] ASoC: tas571x: Add DT binding document Kevin Cernekee
2015-04-15 21:42 ` [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers Kevin Cernekee
[not found] ` <1429134141-17924-2-git-send-email-cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2015-04-16 12:57 ` [alsa-devel] " Lars-Peter Clausen
[not found] ` <552FB1CD.3040401-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-04-18 11:39 ` Mark Brown
2015-04-20 20:56 ` Kevin Cernekee
2015-04-20 21:14 ` Mark Brown
2015-04-18 11:36 ` Mark Brown
[not found] ` <20150418113632.GE26185-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-18 16:16 ` Kevin Cernekee
2015-04-18 17:11 ` Mark Brown
2015-04-18 20:07 ` Kevin Cernekee
[not found] ` <CAJzqFtZ97FjzDpgbSJbCkqNGnQx_QiGrzY1v1zV+croAL6_=qw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-20 12:21 ` Mark Brown
[not found] ` <20150420122129.GC14892-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-20 15:12 ` Kevin Cernekee
2015-04-20 16:05 ` Andrew Bresticker
[not found] ` <CAJzqFtY3-jYTS-NmAE4UtsD+VXZHBUJUVuVQ=X4htB1akCThMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-20 20:14 ` Mark Brown [this message]
[not found] ` <CAJzqFtYVd+jHesoNnG47ftoK9SWYUmXwDXpf2==s3Rv1ewpsYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-24 0:47 ` Kevin Cernekee
2015-04-24 9:28 ` Mark Brown
2015-04-24 13:52 ` Kevin Cernekee
2015-04-24 16:50 ` Mark Brown
[not found] ` <1429134141-17924-1-git-send-email-cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2015-04-15 21:42 ` [PATCH 3/3] MAINTAINERS: Add entry for tas571x ASoC codec driver Kevin Cernekee
2015-04-18 11:16 ` [PATCH 1/3] ASoC: tas571x: Add DT binding document Mark Brown
[not found] ` <20150418111622.GD26185-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-20 21:16 ` Kevin Cernekee
2015-04-20 21:18 ` Kevin Cernekee
2015-04-20 22:03 ` Mark Brown
2015-04-20 22:48 ` Kevin Cernekee
[not found] ` <CAJzqFtbseDe8c19ZpZjw3y72-+eO1+Zcq7D+DC=0G5_LbimRJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-21 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420201401.GP6023@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).