From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v5 05/11] ARM: dts: add imx7d soc dtsi file Date: Wed, 22 Apr 2015 10:12:32 +0100 Message-ID: <20150422091231.GA27345@leverpostej> References: <1429628007-8892-1-git-send-email-Frank.Li@freescale.com> <1429628007-8892-6-git-send-email-Frank.Li@freescale.com> <20150421172834.GF10164@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Zhi Li Cc: "Frank.Li@freescale.com" , "shawn.guo@linaro.org" , "linus.walleij@linaro.org" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Anson Huang List-Id: devicetree@vger.kernel.org On Tue, Apr 21, 2015 at 08:34:45PM +0100, Zhi Li wrote: > >>> + > >>> + clocks { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + > >>> + ckil: clock@0 { > >>> + compatible = "fixed-clock"; > >>> + reg = <0>; > >>> + #clock-cells = <0>; > >>> + clock-frequency = <32768>; > >>> + clock-output-names = "ckil"; > >>> + }; > >>> + > >>> + osc: clock@1 { > >>> + compatible = "fixed-clock"; > >>> + reg = <1>; > >>> + #clock-cells = <0>; > >>> + clock-frequency = <24000000>; > >>> + clock-output-names = "osc"; > >>> + }; > >>> + > >>> + }; > >> > >> Get rid of the clocks container node, and put these under the root. > > > > Okay. > > After remove clocks node. > There will be warning > > Warning (reg_format): "reg" property in /clock@0 has invalid length (4 > bytes) (#address-cells == 1, #size-cells == 1) > Warning (reg_format): "reg" property in /clock@1 has invalid length (4 > bytes) (#address-cells == 1, #size-cells == 1) The reg property is meainingless, so just remove it and give the clocks different names. Mark.