From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings Date: Mon, 27 Apr 2015 13:20:45 +0800 Message-ID: <20150427052045.GA5199@wfg-t540p.sh.intel.com> References: <1429212673-22254-1-git-send-email-rsahu@apm.com> <20150417182937.GN30624@intel.com> <20150427031315.GG2738@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150427031315.GG2738@intel.com> Sender: linux-sparse-owner@vger.kernel.org To: Vinod Koul Cc: Rameshwar Sahu , dan.j.williams@intel.com, dmaengine@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, Christopher Li , Linux-Sparse List-Id: devicetree@vger.kernel.org On Mon, Apr 27, 2015 at 08:43:15AM +0530, Vinod Koul wrote: > On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: > > Hi Vinod, > >> >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); > > >> > > >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver"); > > >> MODULE_AUTHOR("Rameshwar Prasad Sahu "); > > >> -MODULE_AUTHOR("Loc Ho "); > > > And why this? > > > > I saw below warning reported by the kbuild robot test > > > > drivers/dma/xgene-dma.c:2088:1: sparse: symbol > > '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally > > initialized at drivers/dma/xgene-dma.c:2087) > > So, I kept only one author here. > No that is not right, sparse shouldn't have cribbed here. > > Fengguang can we get the bot to ignore this please OK, sorry for the noises! CC sparse maintainer btw. Thanks, Fengguang