From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v3 6/7] ARM: mediatek: dts: Add emmc support to mt8135 Date: Tue, 28 Apr 2015 14:37:25 +0200 Message-ID: <20150428123725.GK6325@pengutronix.de> References: <1430214525-19198-1-git-send-email-chaotian.jing@mediatek.com> <1430214525-19198-7-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430214525-19198-7-git-send-email-chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chaotian Jing Cc: Rob Herring , Matthias Brugger , Chris Ball , Ulf Hansson , Mark Rutland , James Liao , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hongzhou Yang , Catalin Marinas , bin.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Will Deacon , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , "Joe.C" , Eddie Huang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Apr 28, 2015 at 05:48:44PM +0800, Chaotian Jing wrote: > From: Yingjoe Chen > > Add emmc node for mt8135.dtsi & mt8135-evbp1.dts > > Signed-off-by: Yingjoe Chen > Signed-off-by: Chaotian Jing > --- > arch/arm/boot/dts/mt8135-evbp1.dts | 141 +++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt8135.dtsi | 26 +++++++ > 2 files changed, 167 insertions(+) > > diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts > index 357a91f..6d2fee9 100644 > --- a/arch/arm/boot/dts/mt8135-evbp1.dts > +++ b/arch/arm/boot/dts/mt8135-evbp1.dts > @@ -24,6 +24,147 @@ > }; > }; > > +&mmc0 { > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_pins_default>; > + pinctrl-1 = <&mmc0_pins_uhs>; > + status = "okay"; > + bus-width = <8>; > + max-frequency = <50000000>; > + cap-mmc-highspeed; > + vmmc-supply = <&mt6397_vemc_3v3_reg>; > + non-removable; > + func = "EMMC"; ... > + func = "SDCARD"; These have been removed in earlier versions, right? > diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi > index 4d1ddd9..2c5c4da 100644 > --- a/arch/arm/boot/dts/mt8135.dtsi > +++ b/arch/arm/boot/dts/mt8135.dtsi > @@ -212,5 +212,31 @@ > status = "disabled"; > }; > > + mmc0: mmc@11230000 { > + compatible = "mediatek,mt8135-mmc"; > + reg = <0 0x11230000 0 0x108>; Please use the whole register space for the controller here, not only the one actually used by the registers. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html