Re: [PATCH 1/4] misc: ti-st: use GPIO_LOW for initial value of nshutdown

[Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On Tue, 28 Apr 2015, Eric Nelson wrote:
> On 04/28/2015 04:17 AM, Lee Jones wrote:
> > On Sat, 25 Apr 2015, Eric Nelson wrote:
> > 
> >> All other uses of the nshutdown gpio use macros GPIO_LOW and
> >> GPIO_HIGH to allow changing the pin polarity.
> >>
> >> Do this in gpio_direction_output as well.
> >>
> >> Signed-off-by: Eric Nelson <eric.nelson-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
> >> ---
> >>  drivers/misc/ti-st/st_kim.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Where your cover-letter?
> > 
> 
> /dev/null (I didn't create one).

It's good practice to send cover letters attached to patch-sets.  It
gives a basic overview of what the set is trying to achieve, a nice
succinct centralised change-log and a diff-stat for the entire set.
All very handy information for a Maintainer/reviewer and is likely to
speed-up acceptance times.

> > Why did you even sent me this set?
> > 
> get_maintainer.pl told me to...
> 
> 	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> (commit_signer:2/5=40%,authored:2/5=40%,added_lines:2/12=17%,removed_lines:2/11=18%)

I'd Cc "commit signers" with extreme caution to be honest.  As a rule
I never add them, unless they are the author of, or have made vast
changes to the file you're modifying.

I guess get_maintainer.pl is relating to change e4ebe5f where I was
fixing some Coverity reports.  Bottom line is, I shouldn't be in
receipt of this patch-set.  It's just clogging up my already very
clogged-up inbox.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html