Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Baruch Siach]

Hi Shenwei Wang,

On Wed, Apr 29, 2015 at 09:14:41AM -0500, Shenwei Wang wrote:
> There are 4 versions of the timer hardware on Freescale MXC hardware.
> --Version 0: MX1/MXL
> --Version 1: MX21, MX27.
> --Version 2: MX25, MX31, MX35, MX37, MX51, MX6Q
> --Version 3: MX6DL, MX6SX
> 
> This patch has removed the SoC related codes, and implemented the driver
> directly upon the hardware timer IP version.
> 
> The new driver can be installed via device tree or the direct function
> call to mxc_timer_init in order to support imx legacy systems like MX21
> and MX27.
> 
> For the device tree implementation, the driver is compatible with the current
> bindings like "fsl,imx6q-gpt", but for future dts file, the string like
> "fsl,imx-gpt-v2" without SoC information is recommended.

That is not the usual convention for IP block versions.

Please Cc the devicetree list (added).

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Shenwei Wang]

> -----Original Message-----
> From: Baruch Siach [mailto:baruch@tkos.co.il]
> Sent: 2015年4月29日 9:26
> To: Wang Shenwei-B38339
> Cc: shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> independent of SoCs.
> 
> Hi Shenwei Wang,
> 
> On Wed, Apr 29, 2015 at 09:14:41AM -0500, Shenwei Wang wrote:
> > There are 4 versions of the timer hardware on Freescale MXC hardware.
> > --Version 0: MX1/MXL
> > --Version 1: MX21, MX27.
> > --Version 2: MX25, MX31, MX35, MX37, MX51, MX6Q --Version 3: MX6DL,
> > MX6SX
> >
> > This patch has removed the SoC related codes, and implemented the
> > driver directly upon the hardware timer IP version.
> >
> > The new driver can be installed via device tree or the direct function
> > call to mxc_timer_init in order to support imx legacy systems like
> > MX21 and MX27.
> >
> > For the device tree implementation, the driver is compatible with the
> > current bindings like "fsl,imx6q-gpt", but for future dts file, the
> > string like "fsl,imx-gpt-v2" without SoC information is recommended.
> 
> That is not the usual convention for IP block versions.
> 
> Please Cc the devicetree list (added).
>
Thank you for the comments. What is the current naming rules for IP block version? It would be appreciated if you could provide an example.

Shenwei 
 
> baruch
> 
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Baruch Siach]

Hi Shenwei Wang,

On Wed, Apr 29, 2015 at 02:55:52PM +0000, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Baruch Siach [mailto:baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org]
> > Sent: 2015年4月29日 9:26
> > To: Wang Shenwei-B38339
> > Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> > independent of SoCs.
> > 
> > On Wed, Apr 29, 2015 at 09:14:41AM -0500, Shenwei Wang wrote:
> > > There are 4 versions of the timer hardware on Freescale MXC hardware.
> > > --Version 0: MX1/MXL
> > > --Version 1: MX21, MX27.
> > > --Version 2: MX25, MX31, MX35, MX37, MX51, MX6Q
> > > --Version 3: MX6DL, MX6SX
> > >
> > > This patch has removed the SoC related codes, and implemented the
> > > driver directly upon the hardware timer IP version.
> > >
> > > The new driver can be installed via device tree or the direct function
> > > call to mxc_timer_init in order to support imx legacy systems like
> > > MX21 and MX27.
> > >
> > > For the device tree implementation, the driver is compatible with the
> > > current bindings like "fsl,imx6q-gpt", but for future dts file, the
> > > string like "fsl,imx-gpt-v2" without SoC information is recommended.
> > 
> > That is not the usual convention for IP block versions.
> > 
> > Please Cc the devicetree list (added).
>
> Thank you for the comments. What is the current naming rules for IP block 
> version? It would be appreciated if you could provide an example.

When several SoC share the same IP block the usual convention is to name it in 
the compatible property string after the first SoC it appeared on. Just look 
at some binding documentation from Documentation/devicetree/bindings/timer/ to 
find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and 
A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and so 
on.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Shenwei Wang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3119 bytes --]

Hi Baruch,

> -----Original Message-----
> From: Baruch Siach [mailto:baruch@tkos.co.il]
> Sent: 2015年4月29日 10:08
> To: Wang Shenwei-B38339
> Cc: shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> independent of SoCs.
> 
> Hi Shenwei Wang,
> 
> On Wed, Apr 29, 2015 at 02:55:52PM +0000, Shenwei Wang wrote:
> > > -----Original Message-----
> > > From: Baruch Siach [mailto:baruch@tkos.co.il]
> > > Sent: 2015年4月29日 9:26
> > > To: Wang Shenwei-B38339
> > > Cc: shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org
> > > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver
> > > implementation independent of SoCs.
> > >
> > > On Wed, Apr 29, 2015 at 09:14:41AM -0500, Shenwei Wang wrote:
> > > > There are 4 versions of the timer hardware on Freescale MXC hardware.
> > > > --Version 0: MX1/MXL
> > > > --Version 1: MX21, MX27.
> > > > --Version 2: MX25, MX31, MX35, MX37, MX51, MX6Q --Version 3:
> > > > MX6DL, MX6SX
> > > >
> > > > This patch has removed the SoC related codes, and implemented the
> > > > driver directly upon the hardware timer IP version.
> > > >
> > > > The new driver can be installed via device tree or the direct
> > > > function call to mxc_timer_init in order to support imx legacy
> > > > systems like
> > > > MX21 and MX27.
> > > >
> > > > For the device tree implementation, the driver is compatible with
> > > > the current bindings like "fsl,imx6q-gpt", but for future dts
> > > > file, the string like "fsl,imx-gpt-v2" without SoC information is
> recommended.
> > >
> > > That is not the usual convention for IP block versions.
> > >
> > > Please Cc the devicetree list (added).
> >
> > Thank you for the comments. What is the current naming rules for IP
> > block version? It would be appreciated if you could provide an example.
> 
> When several SoC share the same IP block the usual convention is to name it in
> the compatible property string after the first SoC it appeared on. Just look at
> some binding documentation from Documentation/devicetree/bindings/timer/ to
> find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and
> A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and
> so on.
> 
If the same IP block is shared with several SoCs, why we gave them different compatible 
strings? If no changes in an IP block, I assume no changes in the relating driver as well. 
In this assumption, I don't see any need to introduce a new compatible string for an 
unchanged IP block in a new SoC.

Shenwei
> baruch
> 
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i

Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Baruch Siach]

Hi Shenwei Wang,
On Wed, Apr 29, 2015 at 03:19:19PM +0000, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Baruch Siach [mailto:baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org]
> > Sent: 2015年4月29日 10:08
> > To: Wang Shenwei-B38339
> > Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> > independent of SoCs.
> >
> > When several SoC share the same IP block the usual convention is to name 
> > it in
> > the compatible property string after the first SoC it appeared on. Just look at
> > some binding documentation from Documentation/devicetree/bindings/timer/ to
> > find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and
> > A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and
> > so on.
>
> If the same IP block is shared with several SoCs, why we gave them different compatible 
> strings? If no changes in an IP block, I assume no changes in the relating driver as well. 
> In this assumption, I don't see any need to introduce a new compatible string for an 
> unchanged IP block in a new SoC.

That is exactly what I meant to say. Sorry that I was not clear enough.

When the same IP block is used in a newer generation SoC the same compatible 
property string is used. For that reason you can find in sun5i-a10s.dtsi the 
line

	compatible = "allwinner,sun5i-a13-hstimer";

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.

[Shenwei Wang]

Hi Baruch,

> -----Original Message-----
> From: Baruch Siach [mailto:baruch@tkos.co.il]
> Sent: 2015年4月29日 10:25
> To: Wang Shenwei-B38339
> Cc: shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> independent of SoCs.
> 
> Hi Shenwei Wang,
> On Wed, Apr 29, 2015 at 03:19:19PM +0000, Shenwei Wang wrote:
> > > -----Original Message-----
> > > From: Baruch Siach [mailto:baruch@tkos.co.il]
> > > Sent: 2015年4月29日 10:08
> > > To: Wang Shenwei-B38339
> > > Cc: shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org
> > > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver
> > > implementation independent of SoCs.
> > >
> > > When several SoC share the same IP block the usual convention is to
> > > name it in the compatible property string after the first SoC it
> > > appeared on. Just look at some binding documentation from
> > > Documentation/devicetree/bindings/timer/ to find examples. The
> > > allwinner,sun5i-a13-hstimer property is shared by A10s and
> > > A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8
> > > SoCs, and so on.
> >
> > If the same IP block is shared with several SoCs, why we gave them
> > different compatible strings? If no changes in an IP block, I assume no changes
> in the relating driver as well.
> > In this assumption, I don't see any need to introduce a new compatible
> > string for an unchanged IP block in a new SoC.
> 
> That is exactly what I meant to say. Sorry that I was not clear enough.
> 
> When the same IP block is used in a newer generation SoC the same compatible
> property string is used. For that reason you can find in sun5i-a10s.dtsi the line
> 
> 	compatible = "allwinner,sun5i-a13-hstimer";
> 
That is what has been supported in this patch. Besides that, it can also support
different IP block versions in a SoC with different revision. For example,
Let's say: 
	hstimer version 1  in A13 revision 1.0
	hstimer version 2  in A13 revision 1.1

Shenwei


> baruch
> 
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -