[PATCH] clk: bindings: Fix assigned-clock-rates property name

[PATCH] clk: bindings: Fix assigned-clock-rates property name

[Krzysztof Kozlowski]

In documentation the "assigned-clock-parents" name was used when
describing the "assigned-clock-rates" property.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
index 06fc6d541c89..bf5b0414dc17 100644
--- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
+++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
@@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
 and clock frequencies. Such a configuration can be specified in a device tree
 node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
 properties. The assigned-clock-parents property should contain a list of parent
-clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
+clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
 property the list of assigned clock frequency values - corresponding to clocks
 listed in the assigned-clocks property.
 
-- 
1.9.1

Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name

[Stephen Boyd]

On 05/06, Krzysztof Kozlowski wrote:
> In documentation the "assigned-clock-parents" name was used when
> describing the "assigned-clock-rates" property.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---

Looks right. The whole sentence could use some work though.

>  Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> index 06fc6d541c89..bf5b0414dc17 100644
> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
>  and clock frequencies. Such a configuration can be specified in a device tree
>  node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
>  properties. The assigned-clock-parents property should contain a list of parent
> -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
> +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
>  property the list of assigned clock frequency values - corresponding to clocks

This half-sentence:

	The assigned-clock-ratse property the list of assigned
	clock frequency values

doesn't read correctly. Maybe the whole thing should be rewritten
as:

	The assigned-clock-parents property should contain a list
	of parent clocks in the form of a phandle and clock
	specifier pair and the assigned-clock-rates property
	should contain a list of frequencies in Hz. Both these
	properties should correspond to the clocks listed in the
	assigned-clocks property.

>  listed in the assigned-clocks property.
>  

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name

[Krzysztof Kozlowski]

On 06.05.2015 16:45, Stephen Boyd wrote:
> On 05/06, Krzysztof Kozlowski wrote:
>> In documentation the "assigned-clock-parents" name was used when
>> describing the "assigned-clock-rates" property.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> ---
>
> Looks right. The whole sentence could use some work though.
>
>>   Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
>> index 06fc6d541c89..bf5b0414dc17 100644
>> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
>> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
>> @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
>>   and clock frequencies. Such a configuration can be specified in a device tree
>>   node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
>>   properties. The assigned-clock-parents property should contain a list of parent
>> -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
>> +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
>>   property the list of assigned clock frequency values - corresponding to clocks
>
> This half-sentence:
>
> 	The assigned-clock-ratse property the list of assigned
> 	clock frequency values
>
> doesn't read correctly. Maybe the whole thing should be rewritten
> as:
>
> 	The assigned-clock-parents property should contain a list
> 	of parent clocks in the form of a phandle and clock
> 	specifier pair and the assigned-clock-rates property
> 	should contain a list of frequencies in Hz. Both these
> 	properties should correspond to the clocks listed in the
> 	assigned-clocks property.

Looks much better. So actually this should be yours patch now, you can 
add my Reported-by :).

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] clk: bindings: Fix assigned-clock-rates description

[Stephen Boyd]

The binding uses assigned-clock-parents when it should use
assigned-clock-rates. Furthermore, the part that describes how
they relate to the assigned-clocks property is not clear about
what is related. Correct and clarify this part of the binding.

Reported-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
---

On 05/06, Krzysztof Kozlowski wrote:
> Looks much better. So actually this should be yours patch now, you
> can add my Reported-by :).

Ok. I'll queue up this patch unless there are any other objections.

 Documentation/devicetree/bindings/clock/clock-bindings.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
index 06fc6d541c89..2ec489eebe72 100644
--- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
+++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
@@ -138,9 +138,10 @@ Some platforms may require initial configuration of default parent clocks
 and clock frequencies. Such a configuration can be specified in a device tree
 node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
 properties. The assigned-clock-parents property should contain a list of parent
-clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
-property the list of assigned clock frequency values - corresponding to clocks
-listed in the assigned-clocks property.
+clocks in the form of a phandle and clock specifier pair and the
+assigned-clock-rates property should contain a list of frequencies in Hz. Both
+these properties should correspond to the clocks listed in the assigned-clocks
+property.
 
 To skip setting parent or rate of a clock its corresponding entry should be
 set to 0, or can be omitted if it is not followed by any non-zero entry.
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clk: bindings: Fix assigned-clock-rates description

[Stephen Boyd]

On 05/07, Stephen Boyd wrote:
> The binding uses assigned-clock-parents when it should use
> assigned-clock-rates. Furthermore, the part that describes how
> they relate to the assigned-clocks property is not clear about
> what is related. Correct and clarify this part of the binding.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> ---
> 
> On 05/06, Krzysztof Kozlowski wrote:
> > Looks much better. So actually this should be yours patch now, you
> > can add my Reported-by :).
> 
> Ok. I'll queue up this patch unless there are any other objections.
> 

Applied to clk-next.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html