devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Bintian <bintian.wang@huawei.com>
Cc: "dan.zhao@hisilicon.com" <dan.zhao@hisilicon.com>,
	"btw@mail.itp.ac.cn" <btw@mail.itp.ac.cn>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"wangbinghui@hisilicon.com" <wangbinghui@hisilicon.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"huxinwei@huawei.com" <huxinwei@huawei.com>,
	"haojian.zhuang@linaro.org" <haojian.zhuang@linaro.org>,
	"yanhaifeng@gmail.com" <yanhaifeng@gmail.com>,
	"rob.herring@linaro.org" <rob.herring@linaro.org>,
	"mturquette@linaro.org" <mturquette@linaro.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"khilman@kernel.org" <khilman@kernel.org>,
	"xuwei5@hisilicon.com" <xuwei5@hisilicon.com>,
	"jh80.chung@samsung.com" <jh80.chung@samsung.com>,
	"sledge.yanwei@huawei.com" <sledge.yanwei@huawei.com>,
	"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
	"heyunlei@huawei.com" <heyunlei@huawei.com>,
	"w.f@huawei.com" <w.f@huawei.com>"zhangfei.gao@linaro.org" <zh>
Subject: Re: [PATCH v4 5/5] arm64: dts: Add dts files for Hisilicon Hi6220 SoC
Date: Wed, 6 May 2015 11:55:58 +0100	[thread overview]
Message-ID: <20150506104856.GC707@leverpostej> (raw)
In-Reply-To: <5549EE97.3020801@huawei.com>

Hi,

> > I think that given that we know the UART is not quite a PL011 we should
> > add an additional compatible string just in case some difference crops
> > up later that is problematic.
> >
> > So we'd have something like:
> >
> > 	compatible = "hisilicon,hi6220-uart", "arm,pl011", "arm,primecell";
> >
> > That way we can add any optimisations or workarounds later as required.
> I understand and thanks for your suggestion.
> 
> Can I do not do this work in this patch set? Because I got the
> information UART0 is PL011 compatible. Hisilicon uart engineer can do
> this work in the future, maybe for UART1/UART2.

I am not asking you to do any driver work for this -- the current driver
should ignore the "hisilicon,hi6220-uart" string and recognise
"arm,pl011".

I am only asking you to add the additional string to the DTS, and to
update the binding document to list the new string. That way if and when
we need the kernel to distinguish between a regular PL011 and the
hi6220-specific variant, the DTB does not need to be updated in order to
do so.

Is UART 0 different from UART1 and UART2?

Thanks,
Mark.

  reply	other threads:[~2015-05-06 10:55 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 12:06 [PATCH v4 0/5] arm64,hi6220: Enable Hisilicon Hi6220 SoC Bintian Wang
2015-05-05 12:06 ` [PATCH v4 2/5] arm64: hi6220: Document devicetree bindings for Hisilicon hi6220 SoC Bintian Wang
2015-05-15  0:27   ` Stephen Boyd
     [not found]     ` <20150515002739.GF31753-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-15  1:31       ` Bintian
     [not found] ` <1430827599-11560-1-git-send-email-bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-05-05 12:06   ` [PATCH v4 1/5] arm64: Enable Hisilicon ARMv8 SoC family in Kconfig and defconfig Bintian Wang
2015-05-05 12:06   ` [PATCH v4 3/5] clk: hi6220: Document devicetree bindings for hi6220 clock Bintian Wang
2015-05-15  0:26     ` Stephen Boyd
2015-05-05 12:06   ` [PATCH v4 4/5] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC Bintian Wang
2015-05-15  0:25     ` Stephen Boyd
2015-05-15  7:42       ` Bintian
2015-05-15 19:30         ` Stephen Boyd
2015-05-16  2:54           ` Brent Wang
2015-05-19 20:35             ` Stephen Boyd
     [not found]               ` <555B9E7B.9000809-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-20  0:52                 ` Bintian
2015-05-05 12:06   ` [PATCH v4 5/5] arm64: dts: Add dts files for Hisilicon Hi6220 SoC Bintian Wang
2015-05-05 17:13     ` Mark Rutland
2015-05-06  3:16       ` Bintian
2015-05-06  3:51         ` Leo Yan
2015-05-06  9:20           ` Mark Rutland
2015-05-06 11:17             ` Leo Yan
2015-05-06  6:50         ` Bintian
2015-05-06  9:30           ` Mark Rutland
2015-05-06 10:36             ` Bintian
2015-05-06 10:55               ` Mark Rutland [this message]
2015-05-06 15:31                 ` Brent Wang
2015-05-06 15:44                   ` Mark Rutland
2015-05-06 16:03                     ` Brent Wang
2015-05-06 16:23                       ` Mark Rutland
2015-05-06 17:15                         ` Brent Wang
2015-05-07  7:24                           ` Bintian
2015-05-13  7:12                 ` Bintian Wang
2015-05-13  7:30                   ` Bintian
2015-05-06 10:38             ` Haojian Zhuang
2015-05-06 11:01               ` Mark Rutland
2015-05-05 13:45   ` [PATCH v4 0/5] arm64,hi6220: Enable " Haojian Zhuang
2015-05-13  7:33   ` Bintian
2015-05-13  9:16     ` Will Deacon
2015-05-13  9:19       ` Arnd Bergmann
2015-05-13 10:17       ` Bintian
2015-05-05 23:46 ` Tyler Baker
2015-05-06 10:46   ` Bintian
2015-05-07  9:02 ` Will Deacon
2015-05-07  9:29   ` Bintian
2015-05-07 11:25     ` Will Deacon
2015-05-07 11:55       ` Leo Yan
2015-05-07 12:01       ` Bintian
2015-05-07 12:57         ` Will Deacon
2015-05-07 13:06           ` Bintian
2015-05-07  9:33   ` Haojian Zhuang
2015-05-07 10:44     ` Jorge Ramirez-Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150506104856.GC707@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=bintian.wang@huawei.com \
    --cc=btw@mail.itp.ac.cn \
    --cc=dan.zhao@hisilicon.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=heyunlei@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=jh80.chung@samsung.com \
    --cc=khilman@kernel.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=mturquette@linaro.org \
    --cc=rob.herring@linaro.org \
    --cc=sledge.yanwei@huawei.com \
    --cc=w.f@huawei.com \
    --cc=wangbinghui@hisilicon.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yanhaifeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).