From: Gregory Fong <gregory.0xf0@gmail.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot <gnurou@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Brian Norris <computersforpeace@gmail.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/3] gpio: Add GPIO support for Broadcom STB SoCs
Date: Thu, 7 May 2015 21:19:21 -0700 [thread overview]
Message-ID: <20150508041921.GA26702@corellia.local> (raw)
In-Reply-To: <1430986729.8171.41.camel@x220>
On Thu, May 07, 2015 at 10:18:49AM +0200, Paul Bolle wrote:
> Just a nit: a license mismatch.
>
> On Wed, 2015-05-06 at 01:37 -0700, Gregory Fong wrote:
> > --- /dev/null
> > +++ b/drivers/gpio/gpio-brcmstb.c
>
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation version 2.
> > + *
> > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> > + * kind, whether express or implied; without even the implied warranty
> > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
>
> This states the license is GPL v2.
>
> > +MODULE_LICENSE("GPL");
>
> And, according to include/linux/module.h, this states the license is GPL
> v2 or later. So I think either the comment at the top of this file or
> the ident used in the MODULE_LICENSE() macro needs to change.
Will fix that, thanks.
Gregory
next prev parent reply other threads:[~2015-05-08 4:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 8:37 [PATCH 0/3] GPIO support for BRCMSTB Gregory Fong
2015-05-06 8:37 ` [PATCH 1/3] dt-bindings: add brcmstb-gpio GPIO binding Gregory Fong
[not found] ` <1430901477-10678-2-git-send-email-gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-12 10:43 ` Linus Walleij
[not found] ` <1430901477-10678-1-git-send-email-gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-06 8:37 ` [PATCH 2/3] gpio: Add GPIO support for Broadcom STB SoCs Gregory Fong
2015-05-07 8:18 ` Paul Bolle
2015-05-08 4:19 ` Gregory Fong [this message]
2015-05-12 10:55 ` Linus Walleij
2015-05-12 18:46 ` Gregory Fong
2015-05-13 8:52 ` Linus Walleij
2015-05-06 8:37 ` [PATCH 3/3] gpio: brcmstb: Add interrupt support Gregory Fong
2015-05-12 10:59 ` [PATCH 0/3] GPIO support for BRCMSTB Linus Walleij
2015-05-12 19:38 ` Gregory Fong
[not found] ` <CADtm3G45-u82Rp_0dHf2EfdMokf8E4FaQ84PHnocpvXxU+5_+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-13 8:59 ` Linus Walleij
2015-05-27 3:26 ` Gregory Fong
[not found] ` <CADtm3G4ao=3sHx2F1+V9rwS=jWf6ZdEQi4d24HxQ6MEc+CQ8CQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-02 9:05 ` Linus Walleij
[not found] ` <CACRpkdY_-zq-1srBC213MK_RoVvPsfTpRTQyx-4yRvCOV5JdxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-02 16:28 ` Russell King - ARM Linux
2015-06-03 12:46 ` Linus Walleij
2015-06-03 4:13 ` Gregory Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508041921.GA26702@corellia.local \
--to=gregory.0xf0@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).