From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Date: Fri, 8 May 2015 07:49:18 +0100 Message-ID: <20150508064918.GF16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> <20150507191909.GC16220@x1> <20150507195529.GA28554@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150507195529.GA28554@griffinp-ThinkPad-X1-Carbon-2nd> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 07 May 2015, Peter Griffin wrote: > Hi Lee, >=20 > On Thu, 07 May 2015, Lee Jones wrote: >=20 > >=20 > > > > Required properties > > > > =20 > > > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-l= pc" > > > > - "st,stih415-lpc" "st,stid127-lpc" > > > > +- compatible : Must be one of: "st,stih407-lpc" > > >=20 > > > The same comment as the RTC DT patch, you are removing the compat= ibles > > > documentation for the other supported platforms like stih416-lpc. > > > AFAIK they are required in the driver to get the correct sysconfi= g register. > >=20 > > That's intentional. I haven't yet tested any of this IP on > > STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even > > sure if this IP even exists on some of the other platforms. I will > > add them back when support is added to both driver and DTB and I've > > been able to test them. >=20 > That was kind of my point, the driver code AFAIK already contains sup= port > for these SoC's. >=20 > I would either expect the patch to remove support from the DT docs AN= D the > driver, or leave it as is. >=20 > It seems odd to only change the DT docs, and become unaligned to the > code (this assumes I'm looking at the latest patchset here=20 > https://lkml.org/lkml/2015/3/4/1088 which includes support for these = SoCs). The decision to remove these 'supported' platforms was made on the RTC side, where there is only support for "st,stih407-lpc" in the driver. I thought it best to mirror that thought over to the Watchdog LPC bindings, but thought it not really worth ripping out existing support from the driver. If others wish to test/use the Watchdog on other platforms and can read C code, they'll know what to do. Hopefully all of this will be a non-issue anyway, as I plan to test this on the other boards I have in my farm and make the necessary changes in the upcoming weeks. All should be squared away by the next merge-window. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html