From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] imx27: dt: only map 1 Kbyte for fec registers
Date: Mon, 11 May 2015 20:01:01 +0800 [thread overview]
Message-ID: <20150511120101.GA25495@tiger> (raw)
In-Reply-To: <1431204870-17233-1-git-send-email-tremyfr@gmail.com>
On Sat, May 09, 2015 at 10:54:30PM +0200, Philippe Reynes wrote:
> According to the imx27 documentation, fec has a 1 Kbyte
> memory space map, spitted in two regions of 512 bytes.
> The first one for control/status registers, and the
> second one for event/statistic registers. So, we don't
> need to map 16 Kbyte for registers, 1 Kbyte is enough.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> arch/arm/boot/dts/imx27.dtsi | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 6951b66..56bb917 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -533,7 +533,7 @@
>
> fec: ethernet@1002b000 {
> compatible = "fsl,imx27-fec";
> - reg = <0x1002b000 0x4000>;
> + reg = <0x1002b000 0x400>;
No. Per MCIMX27RM.pdf, Table 2-7. AIPI2 Memory Map, it should be 4KiB.
Shawn
> interrupts = <50>;
> clocks = <&clks IMX27_CLK_FEC_IPG_GATE>,
> <&clks IMX27_CLK_FEC_AHB_GATE>;
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-05-11 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:54 [PATCH] imx27: dt: only map 1 Kbyte for fec registers Philippe Reynes
2015-05-11 12:01 ` Shawn Guo [this message]
2015-05-11 21:25 ` Philippe Reynes
[not found] ` <55511E34.5040908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-12 7:01 ` Uwe Kleine-König
2015-05-12 22:21 ` Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511120101.GA25495@tiger \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).