From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org Subject: Re: [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller Date: Tue, 12 May 2015 15:00:57 +0200 Message-ID: <20150512130057.GC4447@schokonusskuchen.bad> References: <1430901427-65146-1-git-send-email-eddie.huang@mediatek.com> <1430901427-65146-4-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Return-path: Content-Disposition: inline In-Reply-To: <1430901427-65146-4-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eddie Huang Cc: Sascha Hauer , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matthias Brugger , Jean Delvare , David Box , Doug Anderson , Zhangfei Gao , Max Schwarz , Boris BREZILLON , Anders Berg , Neelesh Gupta , Lee Jones , Arnd Bergmann , Ray Jui , Simon Glass , Wei Yan , Beniamino Galvani , Xudong Chen , Liguo List-Id: devicetree@vger.kernel.org --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (i2c->irq_stat & I2C_RS_TRANSFER) > + dev_dbg(i2c->dev, "addr: %x, restart transfer interrupt.\n", > + msgs->addr); I'd tend to leave out this debug message. But you may leave it if you like. Rest of the patch looks okay. Thanks! --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJVUfmJAAoJEBQN5MwUoCm2DdoP/3ZYoROZlW7IDuykTUQw4iUl 5dalmTI1vfkGW9EUBKCda6VawpgAMCD2ZED98QLIVnAiIr9R+V5QAts55pZhCuRF DMZjUQBeyhgFg3I5WQ6tyv2BH2J1UaTgR1NASf/KNwkQPxdafmySePiSkdmKFVgv UEGPulLfpwEC2pvfwuzQKrQFawp30L5j+tYB4l169CBUIHhCE6juXIZXM5/+5fTc Iz6F+xKsoRXqZejO1r/uUs2tKruzOxwxLl91WJNJZGvccq2Ycuusw/+csxuTMzjO XEnq9DjCcy9s4rNrUdJjJlQS1T6+SJezLlj05+6N7/juto/LhrMkB4pdVTGsvsEL qLs3AjaC/MeMkIuzl/umFP4UdbwEsi0AgB0NF2o2dDEXCE5TTRMlaMXp79tCtK8s 8N/hN7W1lZvP5fgeqs79Tw8ZUfZhEw9D1KZ+frHYD5JXvET0JeFPqEhucW2hZ7rp yDl5FyZke7dkUuIs7/nBZtG7KbFeFutKkRgDXYRIhk7oURuHfkHJkLMHtdHJFOUD 9ZoaOSHGi7UGAvXoOosMGtido/tyGBmE5bOdrnbOdqhGXqDW7IqTekfuo0yyCLal YepaTyCWpYo2DiBZKYJLI7S/jtubRNJVYO3hP6BoW5n8CnsHd8B6UHU4MClwroL4 L+ymMrCbeRoT26Ct7/4u =1Pos -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--