From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts. Date: Thu, 14 May 2015 11:30:40 +0100 Message-ID: <20150514103040.GN2345@e106497-lin.cambridge.arm.com> References: <1431537092-19597-1-git-send-email-Liviu.Dudau@arm.com> <1431537092-19597-3-git-send-email-Liviu.Dudau@arm.com> <1431596142.2881.13.camel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1431596142.2881.13.camel@linaro.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: "Jon Medhurst (Tixy)" Cc: Arnd Bergmann , Olof Johansson , Rob Herring , Mark Rutland , Ian Campbell , Marc Zyngier , Catalin Marinas , Will Deacon , Sudeep Holla , devicetree , LAKML , LKML List-Id: devicetree@vger.kernel.org On Thu, May 14, 2015 at 10:35:42AM +0100, Jon Medhurst (Tixy) wrote: > On Wed, 2015-05-13 at 18:11 +0100, Liviu Dudau wrote: > > Prepare the device tree for adding more boards based on Juno r0. > >=20 > > Signed-off-by: Liviu Dudau > > --- > > arch/arm64/boot/dts/arm/juno-base.dtsi | 125 +++++++++++++++++++++= ++++++++++++ > > arch/arm64/boot/dts/arm/juno.dts | 122 +--------------------= ----------- >=20 >=20 > What criteria were used to select the contents of juno-base.dtsi? > From what I can see, the stuff left out of base is still the same for= r0 > and r1 (cpu, pmu, memory, psci!). And so juno-r1.dts could just be >=20 > ---------------------------------------------------------------------= ---- > #include "juno.dts" >=20 > / { > model =3D "ARM Juno development board (r1)"; >=20 > }; >=20 > &memtimer { > status =3D "okay"; > }; > ---------------------------------------------------------------------= ---- >=20 > Yes, it's a bit hacky, but avoids duplication of source code. >=20 > I can only assume there are come non-public differences between r0 an= d > r1? Hi Tixy, There are potential differences. Cortex-A53 cluster in r1 has limited CPUfreq functionality due to a chip errata and there were talks interna= lly to actually disable it, hence the reason for keeping CPUs outside the juno-base.dtsi. r2 will have a different set of big CPUs as well, so th= is is preparing for the future as well. PMU are linked to the CPUs, hence the reason they stayed. As for the memory and psci nodes the thinking behind it was mostly to allow for ACPI to make changes there, but it does look now like retrofitting an explanation to something that I did not give too much thought at that moment. Best regards, Liviu >=20 > --=20 > Tixy >=20 --=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- =C2=AF\_(=E3=83=84)_/=C2=AF