devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency
Date: Thu, 14 May 2015 16:20:32 +0100	[thread overview]
Message-ID: <20150514152032.GA29132@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5551217C.9090504@suse.de>

On Mon, May 11, 2015 at 11:39:08PM +0200, Andreas Färber wrote:
> Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux:
> > The SI unit of frequency is Hertz, named after Heinrich Hertz, and is
> > given the symbol "Hz" to denote this.  "hz" is not the unit of frequency,
> > and is in fact meaningless.
> > 
> > Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz
> > contribution to the modern world.
> > 
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Nice. :) Since you're being exact, should it be "Hertz' contribution"?
> 
> > diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts
> > index f5b5a1d96cd7..53ae04f9104d 100644
> > --- a/arch/arm/boot/dts/omap3-cm-t3517.dts
> > +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts
> > @@ -66,7 +66,7 @@
> >  
> >  	otg_drv_vbus: pinmux_otg_drv_vbus {
> >  		pinctrl-single,pins = <
> > -			OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */
> > +			OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */
> 
> This one looks like an identifier - did you check where it comes from
> and whether it needs to be fixed there as well?

There isn't any other reference to it in arch/arm (if there were, the
grep to find these would itself have found it.)

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

      reply	other threads:[~2015-05-14 15:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 13:19 [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency Russell King - ARM Linux
     [not found] ` <20150511131952.GD2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-05-02 14:59   ` Pavel Machek
2015-05-02 14:59 ` Pavel Machek
2015-05-11 19:08 ` Tony Lindgren
2015-05-11 20:18   ` Robert Jarzmik
2015-05-11 21:39 ` Andreas Färber
2015-05-14 15:20   ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514152032.GA29132@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=afaerber@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).