From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 4/6] Watchdog: introdouce "pretimeout" into framework Date: Fri, 15 May 2015 11:01:05 -0700 Message-ID: <20150515180105.GB19230@roeck-us.net> References: <=fu.wei@linaro.org> <1431689090-3125-1-git-send-email-fu.wei@linaro.org> <5555F5C5.8050806@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fu Wei Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Arnd Bergmann , vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jon Masters , Leo Duran , Jon Corbet List-Id: devicetree@vger.kernel.org On Fri, May 15, 2015 at 09:49:07PM +0800, Fu Wei wrote: > Hi Guenter, > > Great thanks for your review, > feedback inline below :-) > > On 15 May 2015 at 21:33, Guenter Roeck wrote: [ ... ] > >> + if (wdd->max_pretimeout && wdd->max_timeout < wdd->max_pretimeout) > >> { > >> + pr_info("Invalid max timeout, resetting to max > >> pretimeout!\n"); > >> + wdd->max_timeout = wdd->max_pretimeout; > >> + } > > > > > > I am a bit concerned about the context dependency introduced here. If > > someone calls > > _init_pretimeout after calling init_timeout, this may result in still > > invalid timeout > > values. > > yes, that logic is not very clean, so my thought is : > maybe we can integrate watchdog_init_timeout and watchdog_init_pretimeout, > if maintainer agree to add pretimeout into framework. > I think we should just assume that Wim will accept it, and try to find the best possible solution (or at least a good one). Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html