From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, shawn.guo@linaro.org,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
a.zummo@towertech.it, sachin.kamat@linaro.org,
p.zabel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, rtc-linux@googlegroups.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/7] arm: imx: power-off: change to syscon to access register
Date: Sat, 16 May 2015 15:54:17 +0200 [thread overview]
Message-ID: <20150516135417.GK3338@piout.net> (raw)
In-Reply-To: <1431696990-23078-2-git-send-email-Frank.Li@freescale.com>
Hi,
On 15/05/2015 at 21:36:24 +0800, Frank.Li@freescale.com wrote :
> static int imx_poweroff_probe(struct platform_device *pdev)
> {
> - snvs_base = of_iomap(pdev->dev.of_node, 0);
> - if (!snvs_base) {
> + struct device_node *nd;
> +
> + nd = of_get_parent(pdev->dev.of_node);
> + if (!nd)
> + return -ENODEV;
> + snvs = syscon_node_to_regmap (nd);
You should remove that space ---^
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-16 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 13:36 [PATCH resend 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li
2015-05-15 13:36 ` [PATCH 1/7] arm: imx: power-off: change to syscon to access register Frank.Li
2015-05-16 13:54 ` Alexandre Belloni [this message]
2015-05-15 13:36 ` [PATCH 2/7] rtc: arm: imx: snvs: change use " Frank.Li
[not found] ` <1431696990-23078-3-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-05-16 14:04 ` Alexandre Belloni
2015-05-15 13:36 ` [PATCH 3/7] Document: dt: fsl: snvs: change support syscon Frank.Li
2015-05-15 13:36 ` [PATCH 4/7] arm: dts: imx: update snvs to use syscon access register Frank.Li
2015-05-18 8:45 ` Philipp Zabel
2015-05-18 19:30 ` Zhi Li
2015-05-18 22:17 ` Alexandre Belloni
2015-05-15 13:36 ` [PATCH 5/7] input: keyboard: imx: add snvs power key driver Frank.Li
2015-05-15 18:27 ` Dmitry Torokhov
2015-05-15 13:36 ` [PATCH 6/7] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li
[not found] ` <1431696990-23078-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-05-15 13:36 ` [PATCH 7/7] arm: dts: imx6sx: enable snvs power key Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-05-15 18:28 ` [PATCH resend 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2015-05-14 17:18 [PATCH " Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-05-14 17:18 ` [PATCH 1/7] arm: imx: power-off: change to syscon to access register Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516135417.GK3338@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=Frank.Li@freescale.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).