From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] max7359_keypad: implement DT bindings Date: Mon, 18 May 2015 09:53:17 -0700 Message-ID: <20150518165317.GC19708@dtor-ws> References: <20150517165502.GA781@fifteen> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150517165502.GA781@fifteen> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, May 17, 2015 at 07:55:02PM +0300, Evgeniy Dushistov wrote: > On Fri, May 15, 2015 at 11:00:02PM +0200, Dmitry Torokhov wrote: > > On Thu, May 14, 2015 at 05:38:03AM +0300, Evgeniy Dushistov wrote: > > > + maxim,debounce_reg = /bits/ 8 <0x5F>; > > > + maxim,ports_reg = /bits/ 8 <0xFF>; > > > > Specifying exact size for properties is quite uncommon; I think the > > usual recommendation is is to use the "standard" u32 and validate the > > range in parser function. > > > > Using of u8 has advantages, it is possible on compilation stage > (dts->dtb) check that you enter right value, but > because of DT validation tools are not part of mainline, > I replace u8 with u32 as you suggest, see patch bellow. If you get DT folks OK on using /bits/ I'm fine with keeping it. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html