From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] pwm: Add support for R-Car PWM Timer
Date: Wed, 20 May 2015 11:06:56 +0900 [thread overview]
Message-ID: <20150520020656.GA31103@verge.net.au> (raw)
In-Reply-To: <SG2PR06MB09195F94EAFBAA73AD19F260D8C20@SG2PR06MB0919.apcprd06.prod.outlook.com>
On Wed, May 20, 2015 at 01:24:32AM +0000, Yoshihiro Shimoda wrote:
> Hi Morimoto-san,
>
> > Sent: Wednesday, May 20, 2015 9:06 AM
> >
> > Hi Shimoda-san
> >
> > I guess previous Geert's opinion about compatible is...
> >
> > > +Required Properties:
> > > +- compatible: should be one of the following.
> > > + - "renesas,pwm-r8a7778": for R-Car M1A
> > > + - "renesas,pwm-r8a7779": for R-Car H1
> > > + - "renesas,pwm-r8a7790": for R-Car H2
> > > + - "renesas,pwm-r8a7791": for R-Car M2-W
> > > + - "renesas,pwm-r8a7794": for R-Car E2
> > (snip)
> > > +static const struct of_device_id rcar_pwm_of_table[] = {
> > > + { .compatible = "renesas,pwm-r8a7778", },
> > > + { .compatible = "renesas,pwm-r8a7779", },
> > > + { .compatible = "renesas,pwm-r8a7790", },
> > > + { .compatible = "renesas,pwm-r8a7791", },
> > > + { .compatible = "renesas,pwm-r8a7794", },
> > > + { },
> > > +};
> >
> > - compatible: should be one of the following.
> > - "renesas,pwm-rcar": for R-Car <=
> > ... /* we need gen1 / gen2 here ? */
> > - "renesas,pwm-r8a7778": for R-Car M1A
> > - "renesas,pwm-r8a7779": for R-Car H1
> > - "renesas,pwm-r8a7790": for R-Car H2
> > - "renesas,pwm-r8a7791": for R-Car M2-W
> > - "renesas,pwm-r8a7794": for R-Car E2
> >
> > static const struct of_device_id rcar_pwm_of_table[] = {
> > { .compatible = "renesas,pwm-rcar", }, <=
> > { },
>
> Thank you for your comment.
> I understood it. If such a document and code, there is similar with the sh-sci driver.
> So, I will fix this patch set.
Does the documentation (e.g. datasheet) indicate that the PWM blocks are
the same for at least all of the R-Car SoCs that we know about?
next prev parent reply other threads:[~2015-05-20 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 10:42 [PATCH v2 0/2] pwm: Add support for R-Car PWM Timer Yoshihiro Shimoda
2015-05-19 10:42 ` [PATCH v2 1/2] pwm: Add device tree binding document " Yoshihiro Shimoda
2015-05-19 10:42 ` [PATCH v2 2/2] pwm: Add support " Yoshihiro Shimoda
2015-05-20 0:06 ` Kuninori Morimoto
2015-05-20 1:24 ` Yoshihiro Shimoda
2015-05-20 2:06 ` Simon Horman [this message]
2015-05-20 2:36 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520020656.GA31103@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).